Skip to content

BIP141: commitment clarification. BIP144: new diagram#367

Merged
luke-jr merged 1 commit intobitcoin:masterfrom
jl2012:bip141commitment
Apr 8, 2016
Merged

BIP141: commitment clarification. BIP144: new diagram#367
luke-jr merged 1 commit intobitcoin:masterfrom
jl2012:bip141commitment

Conversation

@jl2012
Copy link
Copy Markdown
Contributor

@jl2012 jl2012 commented Apr 8, 2016

@sipa @CodeShark
BIP141: witness commitment is optional if the block has no witness data
BIP144: new diagram without spelling check lines

@sipa
Copy link
Copy Markdown
Member

sipa commented Apr 8, 2016

In the diagram, for wxtid, flags will always be 0x01 (unless all witnesses are empty, in which case wtxid = txid).

@jl2012 jl2012 force-pushed the bip141commitment branch from 1538d48 to ee744ca Compare April 8, 2016 19:14
@jl2012
Copy link
Copy Markdown
Contributor Author

jl2012 commented Apr 8, 2016

revised.
it is mentioned in the text that wtxid = txid if witnesses are empty

@sipa
Copy link
Copy Markdown
Member

sipa commented Apr 8, 2016

ACK

@luke-jr luke-jr merged commit 2b478b5 into bitcoin:master Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants