Skip to content

Add BIP109 to BIP9 Deployments#396

Closed
chriswheeler wants to merge 1 commit intobitcoin:masterfrom
chriswheeler:bip9-deployments-bip109
Closed

Add BIP109 to BIP9 Deployments#396
chriswheeler wants to merge 1 commit intobitcoin:masterfrom
chriswheeler:bip9-deployments-bip109

Conversation

@chriswheeler
Copy link
Copy Markdown
Contributor

No description provided.

@gmaxwell
Copy link
Copy Markdown
Contributor

gmaxwell commented Jun 1, 2016

This is incorrect. BIP109 prescribes its own activation mechanism which is different from BIP9-- it uses the old IsSuperMajority rolling test.

@chriswheeler
Copy link
Copy Markdown
Contributor Author

The implementation is based on an earlier version of BIP9 - but still I think it would be useful to show somewhere since its using one of the available bits, and is being actively mined on main net.

Could we add a note, or column to the table to convey this? Or a separate table for deployments which are not fully compatible with the current BIP9?

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Jun 1, 2016

BIP9 has never been about more than softforks, and BIP 109 is not that.

Another table with potential conflicts might be useful, but nothing more IMO.

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Jul 15, 2016

Interpreting @gmaxwell 's comment and lack of revisions here as a NACK; closing. Ping me if someone wants it reopened.

@luke-jr luke-jr closed this Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants