Skip to content

Fix Reference to Non-Existent BIPs#412

Closed
super3 wants to merge 2 commits intobitcoin:masterfrom
super3:patch-1
Closed

Fix Reference to Non-Existent BIPs#412
super3 wants to merge 2 commits intobitcoin:masterfrom
super3:patch-1

Conversation

@super3
Copy link
Copy Markdown

@super3 super3 commented Jun 24, 2016

This document was derived from PEP-0001. This line makes reference to BIPs 8 and 7, which don't exist. These are leftover refrences to Python PEPs which establish guidelines for code styles.

Reference to Python PEPs accidentally left in.
@laanwj
Copy link
Copy Markdown
Member

laanwj commented Jun 28, 2016

Thanks for actually reading BIP 1 :) As I've complained before, it's probably the least read 'important' document in bitcoin history.

Shameful ACK

TBH I think you can remove "code style" completely there, BIPs hardly contain code, and if they do (as BIP66 does) there's no code style guideline.

@laanwj "BIPs hardly contain code, and if they do (as BIP66 does) there's no code style guideline"
@maflcko
Copy link
Copy Markdown
Member

maflcko commented Jun 28, 2016

ACK 291e670

@super3
Copy link
Copy Markdown
Author

super3 commented Jun 28, 2016

@laanwj Good point. Updated the pull request to reflect that.

I maintain that Bitcoin documentation is a bit disjointed. All my pulls into core have been around trying to make stuff more readable. If more people need to read it, needs to be more visible.

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Jun 28, 2016

@genjix

@super3
Copy link
Copy Markdown
Author

super3 commented Aug 21, 2016

@luke-jr @genjix Anything missing from my end, or are we just waiting for more ACKs?

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Sep 2, 2016

@super3 Just waiting for @genjix since he is the sole Author at this point... :/

@jonathancross
Copy link
Copy Markdown
Contributor

Unfortunately @genjix has been MIA for more than a year. Seems we might want to have a backup plan for authors that are not responsive / have abandoned their BIP?

Same applies to #453

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Oct 1, 2016

BIP 1 allows me to reassign BIPs if authors go missing. However, I consider BIP 1 set in stone, and instead would prefer if people make the effort to review BIP 2 as a replacement, which I will be proposing to the mailing list shortly, if there are no further review comments.

@super3
Copy link
Copy Markdown
Author

super3 commented Oct 1, 2016

@luke-jr @genjix Is clearly MIA, so #412 and #453 are in limbo. So to be clear you don't plan on reassigning BIP 1 to another author, but instead plan on trying to get BIP 2 accepted? If so #412 and #453 can probably be closed if/when BIP 2 is accepted.

Is there a current discussion area for BIP 2? I'd like to make some comments.

@maflcko
Copy link
Copy Markdown
Member

maflcko commented Oct 1, 2016

Is there a current discussion area for BIP 2? I'd like to make some comments.

Right now you could send your comment to https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2016-September/013165.html

@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Dec 15, 2016

BIP 1 has been Replaced by BIP 2.

@luke-jr luke-jr closed this Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants