BIP68/113 for generation transaction

[jl2012]

To clarify the applicability of BIP68 and 113 to generation transaction

[luke-jr]

@maaku @btcdrak @NicolasDorier @afk11

[maaku]

This isn't true. The rules apply as much to outputs of a coinbase as they do any other transaction. Is the proposed text talking about the coinbase's nSequence value? Then that should be specified exactly, although I don't think the clarification is necessary (coinbase is already specially treated).

[jl2012]

@maaku, isn't the SequenceLocks is done only for non-coinbase tx?

https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L2480

And we do need to clarify as some miners are using the nSequence as extranonce
(I'm talking about the BIP68, not BIP112)

[luke-jr]

nSequence is about inputs, not outputs... and the new rule for it doesn't make sense for the generation tx input since it's not spending coins.

[afk11]

For 113 (MTP), the generation transaction's locktime is checked, so looks good to me: https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L3602

@jl2012 Maybe clarify by saying 68 doesn't apply to the inputs of the coinbase transaction? It can certainly apply to spends of it's outputs.

[jl2012]

@maaku @afk11 @luke-jr Edited

[maaku]

"of the generation"

Is this the proper terminology? Should we say "coinbase transaction" here? Honestly not sure what the current accepted terminology is.

[btcdrak]

"coinbase tx" is definitely more common.

[luke-jr]

The coinbase is the input scriptSig for the generation transaction.

[maaku]

Right, the sequence lock checks are not done for the coinbase input. The updated text is better (see comment made)

[jl2012]

@maaku @btcdrak fixed

[afk11]

ACK 8d40b6e

[btcdrak]

ACK 8d40b6e

[maaku]

ACK 8d40b6e

[luke-jr]

Disagree with "coinbase transaction", but this is hardly the first time, and an ACK is an ACK...