Conversation
bip-0044.mediawiki
Outdated
| * [[https://samouraiwallet.com/|Samouria Wallet]] ([[https://github.com/Samourai-Wallet/samourai-wallet-android|source]]) | ||
| * [[https://www.darkwallet.is/|Darkwallet]] ([[https://github.com/darkwallet/darkwallet/|source]]) | ||
|
|
||
| * [[https://bitcointrezor.com/|TREZOR]] ([[https://github.com/keepkey/|source]]) |
There was a problem hiding this comment.
Source code links are mixed up (KeepKey source code for TREZOR and vice versa)
bip-0044.mediawiki
Outdated
|
|
||
| * [[https://bitcointrezor.com/|TREZOR]] ([[https://github.com/keepkey/|source]]) | ||
| * [[https://www.keepkey.com/|KeepKey]] ([[https://github.com/trezor/|source]]) | ||
| * [[https://www.ledgerwallet.com/|Ledger Wallet]] ([[https://github.com/trezor/|source]]) |
There was a problem hiding this comment.
Source code link is incorrect, should be https://github.com/LedgerHQ
|
It's hard to find a new line that does not have a typo or factual error in it. NACK until all issues are fixed. |
Mirobit
force-pushed
the
patch-1
branch
2 times, most recently
from
87e1e3e to
350b8e1
Compare
|
Fixed all mix-ups. |
|
@Mirobit I'm not sure about the opinion of others but I'd suggest squashing the commits |
|
@saleemrashid I thought I already squashed the two commits. I only see one now. |
bip-0044.mediawiki
Outdated
| * [[https://samouraiwallet.com/|Samourai Wallet]] ([[https://github.com/Samourai-Wallet/samourai-wallet-android|source]]) | ||
| * [[https://www.darkwallet.is/|Darkwallet]] ([[https://github.com/darkwallet/darkwallet/|source]]) | ||
|
|
||
| * [[https://bitcointrezor.com/|TREZOR]] ([[https://github.com/trezor/|source]]) |
There was a problem hiding this comment.
https://bitcointrezor.com/ redirects to https://trezor.io/
Probably better to use the final URL.
There was a problem hiding this comment.
@jonathancross Yep, TREZOR.io is the new domain
bip-0044.mediawiki
Outdated
| * [[https://play.google.com/store/apps/details?id=com.bonsai.wallet32|Wallet32 (Android)]] ([[https://github.com/ksedgwic/Wallet32|source]]) | ||
| * [[https://maza.club/encompass|Encompass]] ([[https://github.com/mazaclub/encompass|source]]) | ||
| * [[https://www.coinvault.io/|CoinVault]] ([[https://github.com/CoinVault/dotblock|source]]) | ||
| * [[https://cancoin.co/|Cancoin]] ([[https://github.com/cancoin|source]]) |
There was a problem hiding this comment.
The source code for the wallet is not posted at the link provided.
I have some more general concerns about this wallet (see below), but not being Open Source already suggests it should not be listed here.
** This web wallet is not listed in https://bitcoin.org/en/choose-your-wallet , parts are still in beta, their forum doesn't actually exist and their Facebook link is broken.
bip-0044.mediawiki
Outdated
| * [[https://play.google.com/store/apps/details?id=com.bonsai.wallet32|Wallet32 @ Android]] ([[https://github.com/ksedgwic/Wallet32|source]]) | ||
| * [[https://play.google.com/store/apps/details?id=com.mycelium.wallet|Mycelium Bitcoin Wallet (Android)]] ([[https://github.com/mycelium-com/wallet|source]]) | ||
| * [[https://copay.io/|Copay]] ([[https://github.com/bitpay/copay|source]]) | ||
| * [[https://play.google.com/store/apps/details?id=com.bonsai.wallet32|Wallet32 (Android)]] ([[https://github.com/ksedgwic/Wallet32|source]]) |
There was a problem hiding this comment.
FYI: Question about strict BIP-44 compatibility raised here: ksedgwic/Wallet32#17
There was a problem hiding this comment.
I would not include Wallet32 since it has not been updated since 2014.
| * [[https://bitcointrezor.com/|TREZOR]] ([[https://github.com/trezor/|source]]) | ||
| * [[https://www.keepkey.com/|KeepKey]] ([[https://github.com/keepkey/|source]]) | ||
| * [[https://www.ledgerwallet.com/|Ledger Wallet]] ([[https://github.com/LedgerHQ|source]]) | ||
| * [[https://21.co/learn/21-lib-wallet/|21 Machine Wallet]] ([[https://github.com/21dotco|source]]) |
There was a problem hiding this comment.
This is not a wallet for users, but rather developers and I don't think we should include these in the list.
There was a problem hiding this comment.
@prusnak Might be even more of a reason to include it (BIPs are aimed at developers)
|
@jonathancross Thanks. Removed and updated. Also removed Darkwallet and Encompass due to inactivity. |
Multibit is not a BIP-44 compatible wallet as it just supports one account and ignores the rest. |
|
@Mirobit poke |
Typo Fixed github links
|
@luke-jr removed MultiBit. Should be ready to merge now. |
|
ACK |
5 participants
No description provided.