Slight clarification for replacement implementation#488
Merged
luke-jr merged 1 commit intobitcoin:masterfrom Nov 6, 2017
Merged
Slight clarification for replacement implementation#488luke-jr merged 1 commit intobitcoin:masterfrom
luke-jr merged 1 commit intobitcoin:masterfrom
Conversation
harding
approved these changes
Jan 13, 2017
Contributor
harding
left a comment
harding
left a comment
There was a problem hiding this comment.
One nano-nit that can be optionally fixed or left as-is as far as I'm concerned. Otherwise LGTM. Thanks!
bip-0125.mediawiki
Outdated
| # The replacement transaction does not contain any new unconfirmed inputs that did not previously appear in the mempool. (Unconfirmed inputs are inputs spending outputs from currently unconfirmed transactions.) | ||
|
|
||
| # The replacement transaction must pay for its own bandwidth in addition to the amount paid by the original transactions at or above the rate set by the node's minimum relay fee setting. For example, if the minimum relay fee is 1 satoshi/byte and the replacement transaction is 500 bytes total, then the replacement must pay a fee at least 500 satoshis higher than the sum of the originals. | ||
| # The replacement transaction pays an absolute fee at least the sum paid by the original transactions. |
Contributor
There was a problem hiding this comment.
"an absolute fee at least" -> "an absolute fee of at least" (sounds better to my ears, but either way seems fine)
Member
Author
There was a problem hiding this comment.
you're right, updating
Contributor
|
@luke-jr This is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grouped the two sections explaining the fee evaluation, then removed a redundant clause in the middle of the latter paragraph that confused the meaning.
@harding @petertodd ping authors