Skip to content

BIP 148: Mandatory activation of segwit deployment#501

Merged
luke-jr merged 1 commit intobitcoin:masterfrom
shaolinfry:bip-segwit-flagday
Mar 20, 2017
Merged

BIP 148: Mandatory activation of segwit deployment#501
luke-jr merged 1 commit intobitcoin:masterfrom
shaolinfry:bip-segwit-flagday

Conversation

@shaolinfry
Copy link
Copy Markdown
Contributor

No description provided.

@Shic1983
Copy link
Copy Markdown

Compulsory activation ? wtf ?
We're not deciding or voting anything now, no signalling.. someone, somewhere is just forcing this by law ? r u kidding me ? get real. fucking ponker

@is55555
Copy link
Copy Markdown

is55555 commented Mar 19, 2017

An effort to provide a PoW contingency plan is also being started, to provide back up for any eventuality in this transition.

https://bitcointalk.org/index.php?topic=1833391

@seweso
Copy link
Copy Markdown

seweso commented Mar 19, 2017

What might be smart to add is some kind of depth at which blocks are accepted. Maybe also make it configurable. I really like the idea of consensus emerging from the network itself. It's like decentralised consensus finding.

@dabura667
Copy link
Copy Markdown

What might be smart to add is some kind of depth at which blocks are accepted. Maybe also make it configurable. I really like the idea of consensus emerging from the network itself. It's like decentralised consensus finding.

I see what you did there.

@farukuzun
Copy link
Copy Markdown

farukuzun commented Mar 19, 2017

Why did you choose between October 1st 2017 and November 15th 2017?
I don't think this bip acceptable but core developers will come up with something better to prevent miners to takeover the network I hope.

@WaveringAna
Copy link
Copy Markdown

This is just a hardfork, while you're at it, put in a block size increase there too

@farukuzun
Copy link
Copy Markdown

@AayanL segwit already has it

@pdaian
Copy link
Copy Markdown

pdaian commented Mar 19, 2017

I left a clarifying question on the original proposal here: https://gist.github.com/shaolinfry/743157b0b1ee14e1ddc95031f1057e4c#gistcomment-2028169

No answer between when I left it four days ago and when this was submitted as a PR today.

The rationale for the choice of a 2-DoS score is still unclear in the proposal.

Copy link
Copy Markdown
Member

@luke-jr luke-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use BIP number 148, and correct the Copyright section.


==Copyright==

This document is placed in the public domain.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the header (and PD is not an acceptable "license" anymore).

@luke-jr luke-jr changed the title BIP for the mandatory activation of segwit BIP 148: Mandatory activation of segwit deployment Mar 19, 2017
@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Mar 19, 2017

As a reminder to commenters here: discussion of the actual proposal should occur on the bitcoin-dev mailing list, not on the pull request, which will be merged/closed as soon as the process issues are resolved, and without any consideration for the merits of or flaws in the idea.

@hsjoberg
Copy link
Copy Markdown

hsjoberg commented Mar 19, 2017

This is just a hardfork, while you're at it, put in a block size increase there too

No, this is not a hardfork, old legacy nodes will still follow the UASF/softfork chain, should it become the one with most hashing power.

In a hardfork, old nodes would never accept the hardfork chain.

Why did you choose between October 1st 2017 and November 15th 2017?

I think this it so make sure that 0.13.1 and 0.14 nodes would get triggered by the UASF, because that means that it would be 1 month of 100% segwit blocks, triggering the old 95% signaling requirement.


Perhaps requiring ~51% miners support would make the proposal safer?

@shaolinfry
Copy link
Copy Markdown
Contributor Author

shaolinfry commented Mar 19, 2017

@farukuzun Please see the mailing list discussion

@NTOM P2SH was activated by flag day also, see 0.6.0 release

@pdaian DOS score will be up for discussion on final PR as well as potentially using a service bit until Nov 15th. Removed for now.

@luke-jr Done. Unsure why Travis is failing.

@shaolinfry
Copy link
Copy Markdown
Contributor Author

@luke-jr OK Travis errors fixed.

@WriteCodeEveryday
Copy link
Copy Markdown

This is exactly what we need. It shows we at Blockstream own Bitcoin and if you don't align with our vision, you will be crushed like cockroaches.

I wonder how many percentage points off of the original 95% we'll be at when this activates and hard forks those nodes and miners off the network.


==Copyright==

This document dual licensed as BSD-3-Clause and CC0-1.0.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BSD 3-Clause and CC0 1.0: without dashes.

Add hyperlinks to authoritative license deeds.

This document is

@luke-jr luke-jr merged commit 2e0be67 into bitcoin:master Mar 20, 2017
@AllanDoensen
Copy link
Copy Markdown

No miner is going to run code that will put him on a minority chain. I hope blockstream does this real soon cause it will bury blockstream/core forever.

@afk11
Copy link
Copy Markdown
Contributor

afk11 commented Mar 20, 2017

Concept ACK. Better to trigger activation for the >80% of nodes prepared to enforce the rule already.

@shaolinfry shaolinfry deleted the bip-segwit-flagday branch March 20, 2017 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.