Skip to content

BIP 175 Improvements#593

Merged
luke-jr merged 1 commit intobitcoin:masterfrom
jonathancross:bip-175
Oct 2, 2017
Merged

BIP 175 Improvements#593
luke-jr merged 1 commit intobitcoin:masterfrom
jonathancross:bip-175

Conversation

@jonathancross
Copy link
Copy Markdown
Contributor

  • Standardizing spelling of "payer".
  • In examples:
    • Added headings
    • Separated "document 1:" label from the contents which are actually hashed (eg "baz").
  • Misc spelling mistakes.

@omarshibli

@omarshibli
Copy link
Copy Markdown
Contributor

looks good, thanks a lot.
just one small comment regarding the subheadings in Examples section, imho, if you want to make these subheadings, I would consider removing the colon at the end, I don't think colon at the end of string in the contents section would be an aesthetic thing.
examples section screenshot
Thoughts?

@omarshibli
Copy link
Copy Markdown
Contributor

ACK
I will submit a separate PR for subheading style.
@luke-jr

@luke-jr luke-jr merged commit dde2742 into bitcoin:master Oct 2, 2017
@jonathancross jonathancross deleted the bip-175 branch October 8, 2017 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants