Skip to content

bip159: Clarify that there is only one threshold#617

Merged
luke-jr merged 2 commits intobitcoin:masterfrom
maflcko:Mf1712-bip159rework
Dec 19, 2017
Merged

bip159: Clarify that there is only one threshold#617
luke-jr merged 2 commits intobitcoin:masterfrom
maflcko:Mf1712-bip159rework

Conversation

@maflcko
Copy link
Copy Markdown
Member

@maflcko maflcko commented Dec 19, 2017

@jonasschnelli

Changes:

  • The last section mentions "thresholds", while only a single threshold of 244 is specified in the bip. Clarify by changing to "threshold"
  • Remove internal Bitcoin Core implementation detail. This is not relevant for a bip.
  • Remove word "additional" when referring to safety buffer, since the safety buffer is the only buffer and not an additional one.
  • Remove empty section "references"
  • Add missing link to signaling implementation.

@jonasschnelli
Copy link
Copy Markdown
Contributor

Thanks!
ACK f455a24da7b098d390b6405ae19826d0c5684c3e

@maflcko
Copy link
Copy Markdown
Member Author

maflcko commented Dec 19, 2017

Added a link to the signaling implementation after your review.

@jonasschnelli
Copy link
Copy Markdown
Contributor

Also ACK fa9a4f3

@luke-jr luke-jr merged commit 9e0fe1a into bitcoin:master Dec 19, 2017
@maflcko maflcko deleted the Mf1712-bip159rework branch December 19, 2017 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants