BIP 158: Change test vectors from CSV to JSON format.#677
Merged
luke-jr merged 1 commit intobitcoin:masterfrom May 20, 2018
Merged
BIP 158: Change test vectors from CSV to JSON format.#677luke-jr merged 1 commit intobitcoin:masterfrom
luke-jr merged 1 commit intobitcoin:masterfrom
Conversation
The JSON format is standard for Bitcoin Core test data.
aakselrod
approved these changes
May 2, 2018
Contributor
aakselrod
left a comment
aakselrod
left a comment
There was a problem hiding this comment.
utACK. For such small amounts of overhead, it might be more readable to make each test case a dictionary rather than usig a header row comment, but that wouldn't match the bitcoind tests.
Contributor
Author
|
@luke-jr Ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON format is standard for Bitcoin Core test data, and projects that copy test data from Core. This does some additional refactoring to the gentestvectors.go program.
@aakselrod