[BIP174] Fix to unify Test Vector in key order of PSBT Input.#707
Merged
luke-jr merged 1 commit intobitcoin:masterfrom Aug 9, 2018
Merged
[BIP174] Fix to unify Test Vector in key order of PSBT Input.#707luke-jr merged 1 commit intobitcoin:masterfrom
luke-jr merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
ACK 72e60d2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only Test Vector for the updater that sets the SIGHASH Type, the position of the SIGHASH type of the generated PSBT payload deviates from the other Test Vector, it making testing difficult in the program.
Therefore, like other Test Vector, it will better to change the Test Vector to payload generated in order of PSBT keys.