Skip to content

bip158: update test vectors#733

Merged
Roasbeef merged 1 commit intobitcoin:masterfrom
tuxcanfly:bip158-update-tests
Apr 23, 2024
Merged

bip158: update test vectors#733
Roasbeef merged 1 commit intobitcoin:masterfrom
tuxcanfly:bip158-update-tests

Conversation

@tuxcanfly
Copy link
Copy Markdown
Contributor

Added test vector for block 1414221. In particular this block has no output scripts other than OP_RETURN, and it's corresponding filter is 0x00. Also updated the spec to clarify the same.

@tuxcanfly tuxcanfly force-pushed the bip158-update-tests branch from 14f7d59 to d2b1dc9 Compare October 25, 2018 15:54
@luke-jr
Copy link
Copy Markdown
Member

luke-jr commented Dec 14, 2018

@Roasbeef @aakselrod

@Roasbeef
Copy link
Copy Markdown
Contributor

The test vector additions moved over to: #760

Fine with this as is, nothing lost by calling out the explicit case of an empty filter.

Copy link
Copy Markdown
Contributor

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦚

@Roasbeef Roasbeef merged commit 11ceb96 into bitcoin:master Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants