Add SegWit v0 (P2WPKH+P2WSH) filter type#896
Closed
nopara73 wants to merge 3 commits intobitcoin:masterfrom
Closed
Add SegWit v0 (P2WPKH+P2WSH) filter type#896nopara73 wants to merge 3 commits intobitcoin:masterfrom
nopara73 wants to merge 3 commits intobitcoin:masterfrom
Conversation
schildbach
reviewed
Feb 28, 2020
Member
Contributor
Author
|
For the record there is a discussion about that probably it should combine both P2WPKH and P2WSH scripts: bitcoin/bitcoin#18222 (comment) |
Contributor
Author
|
There seems to be a consensus that |
nopara73
changed the title
Contributor
Author
|
This has been rejected, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0x01to theBasicfilter type to reflect Bitcoin Core's codebase.0xFF,Invalidfilter filter type to reflect Bitcoin Core's codebase.0x02,V0filter type, which incorporatesP2WPKH+P2WSHscripts to map to PR Add new filter type v0 for segwit only Scripts to blockfilterindex bitcoin#18223. Thus this PR cannot be merged until Add new filter type v0 for segwit only Scripts to blockfilterindex bitcoin#18223 PR is merged.