Skip to content

BIP66: Number Examples To Match Implementation Tests #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laanwj merged 1 commit into from
Mar 11, 2015
Merged

BIP66: Number Examples To Match Implementation Tests #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions bip-0066.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,19 +102,19 @@ bool static IsValidSignatureEncoding(const std::vector<unsigned char> &sig) {

Notation: P1 and P2 are valid, serialized, public keys. S1 and S2 are valid signatures using respective keys P1 and P2. S1' and S2' are non-DER but otherwise valid signatures using those same keys. F is any invalid but DER-compliant signature (including 0, the empty string). F' is any invalid and non-DER-compliant signature.

* <code>S1' P1 CHECKSIG</code> fails (<b>changed</b>)
* <code>S1' P1 CHECKSIG NOT</code> fails (unchanged)
* <code>F P1 CHECKSIG</code> fails (unchanged)
* <code>F P1 CHECKSIG NOT</code> can succeed (unchanged)
* <code>F' P1 CHECKSIG</code> fails (unchanged)
* <code>F' P1 CHECKSIG NOT</code> fails (<b>changed</b>)

* <code>0 S1' S2 2 P1 P2 2 CHECKMULTISIG</code> fails (<b>changed</b>)
* <code>0 S1' S2 2 P1 P2 2 CHECKMULTISIG NOT</code> fails (unchanged)
* <code>0 F S2' 2 P1 P2 2 CHECKMULTISIG</code> fails (unchanged)
* <code>0 F S2' 2 P1 P2 2 CHECKMULTISIG NOT</code> fails (<b>changed</b>)
* <code>0 S1' F 2 P1 P2 2 CHECKMULTISIG</code> fails (unchanged)
* <code>0 S1' F 2 P1 P2 2 CHECKMULTISIG NOT</code> can succeed (unchanged)
# <code>S1' P1 CHECKSIG</code> fails (<b>changed</b>)
# <code>S1' P1 CHECKSIG NOT</code> fails (unchanged)
# <code>F P1 CHECKSIG</code> fails (unchanged)
# <code>F P1 CHECKSIG NOT</code> can succeed (unchanged)
# <code>F' P1 CHECKSIG</code> fails (unchanged)
# <code>F' P1 CHECKSIG NOT</code> fails (<b>changed</b>)

# <code>0 S1' S2 2 P1 P2 2 CHECKMULTISIG</code> fails (<b>changed</b>)
# <code>0 S1' S2 2 P1 P2 2 CHECKMULTISIG NOT</code> fails (unchanged)
# <code>0 F S2' 2 P1 P2 2 CHECKMULTISIG</code> fails (unchanged)
# <code>0 F S2' 2 P1 P2 2 CHECKMULTISIG NOT</code> fails (<b>changed</b>)
# <code>0 S1' F 2 P1 P2 2 CHECKMULTISIG</code> fails (unchanged)
# <code>0 S1' F 2 P1 P2 2 CHECKMULTISIG NOT</code> can succeed (unchanged)

Note that the examples above show that only additional failures are required by this change, as required for a soft forking change.

Expand Down