Skip to content

bip-0069: Fix Python 3 compatibility by replacing deprecated cmp para… #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bip-0069: Fix Python 3 compatibility by replacing deprecated cmp para… #1986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bip-0069/bip-0069_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ def input_cmp(input_tuple1, input_tuple2):
raise ValueError('Matching previous transaction hash and previous transaction output index for two distinct inputs. Invalid!')

def sort_inputs(input_tuples):
return sorted(input_tuples, cmp=input_cmp)
from functools import cmp_to_key
return sorted(input_tuples, key=cmp_to_key(input_cmp))

def print_inputs(ordered_input_tuples):
index = 0
Expand All @@ -52,7 +53,8 @@ def output_cmp(output_tuple1, output_tuple2):
return bytearr_cmp(output_tuple1[1], output_tuple2[1])

def sort_outputs(output_tuples):
return sorted(output_tuples, cmp=output_cmp)
from functools import cmp_to_key
return sorted(output_tuples, key=cmp_to_key(output_cmp))

def print_outputs(ordered_output_tuples):
index = 0
Expand Down