bip-340: set all_passed=False on key generation mismatch - #2002
Merged
jonatack merged 1 commit intoOct 16, 2025
Merged
Conversation
Member
|
cc @real-or-random for sign-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test harness to correctly fail when public key generation does not match the expected vector. Previously, the “Failed key generation” branch only printed diagnostics without updating all_passed, leading to a false-positive overall test result. This is a bug because a keygen mismatch indicates an implementation error that must cause the test run to fail, consistent with how other failures in the harness set all_passed = False.