BIP324: Fix features bitmask for decoding-case selection #2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
real-or-random
force-pushed
the
202510-fix-gen-test-vectors
branch
from
50a6e6a to
31f1e57
Compare
real-or-random
force-pushed
the
202510-fix-gen-test-vectors
branch
from
31f1e57 to
713f000
Compare
This was referenced Oct 23, 2025
jonatack
added
Proposed BIP modification
Pending acceptance
jonatack
reviewed
Oct 23, 2025
There was a problem hiding this comment.
ACK 713f000
The first commit is the same as the change I previously reviewed and ACKed in #1969, but I didn't previously verify by re-generating the test vectors, which generates the diff we see in the second commit. Re-verified the second commit by running gen_test_vectors.py on it and seeing no change, and ran run_test_vectors.py to sanity-check that the tests pass.
|
ACK code changes; I did not verify the generated output. |
jonatack
removed
the
Pending acceptance
|
Ready for merge then :) |
This was referenced Oct 24, 2025
fanquake
pushed a commit
to bitcoin/bitcoin
that referenced
this pull request
Oct 27, 2025
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Oct 27, 2025
51877f2 test: Update BIP324 test vectors (Tim Ruffing) Pull request description: This updates the hardcoded test vectors from BIP324. The test vectors had to be regenerated (in the aux files of the BIP) because there was a bug in the script used for generating them (bitcoin/bips#2016). ACKs for top commit: jonatack: ACK 51877f2 theStack: ACK 51877f2 Tree-SHA512: 59f4075e286067b11fce98667c860f3083b6cca8a2e49da8783ccdce8e32c34fd3e1943191d24dcf5bb68d8a2540726d99f7c29e8b0f104032ccb82423ca8d82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #1969.
On top of #1969.
I'm one of the authors of BIP324 but let's wait for an ACK from @sipa, please.