Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui: crash when running console commands during startup #16119

Closed
fanquake opened this issue May 29, 2019 · 0 comments · Fixed by #16122
Closed

gui: crash when running console commands during startup #16119

fanquake opened this issue May 29, 2019 · 0 comments · Fixed by #16122
Labels
GUI

Comments

@fanquake
Copy link
Member

Using master. During startup, if you open Window -> Console and try and execute any command (can be garbage) bitcoin-qt will crash:

On branch pull/16118/local-merge

Process 89287 launched: '/Users/michael/github/bitcoin/src/qt/bitcoin-qt' (x86_64)
2019-05-29 09:57:56.276746-0400 bitcoin-qt[89287:939924] MessageTracer: Falling back to default whitelist
Process 89287 stopped
* thread #1, name = 'bitcoin-main', queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x8)
    frame #0: 0x00000001015158ba QtWidgets`QCompleter::popup() const + 10
QtWidgets`QCompleter::popup:
->  0x1015158ba <+10>: movq   0x8(%rdi), %rbx
    0x1015158be <+14>: movq   0x88(%rbx), %rax
    0x1015158c5 <+21>: testq  %rax, %rax
    0x1015158c8 <+24>: jne    0x101515942               ; <+146>
Target 0: (bitcoin-qt) stopped.

Not sure if just disabling the menu, like in #16118 would be ok, as a user might actually want to be able to run a command.
@fanquake fanquake added the GUI label May 29, 2019
@promag promag mentioned this issue May 29, 2019
Merged
laanwj added a commit that referenced this issue Jun 3, 2019
@laanwj
Merge #16122: gui: Enable console line edit on setClientModel
c3723c8 
2d8ad2f gui: Enable console line edit on setClientModel (João Barbosa)

Pull request description:

  Make console line edit disable by default, and only enable once `RPCConsole::setClientModel` is called.

  Fixes #16119.

ACKs for commit 2d8ad2:
  fanquake:
    tACK 2d8ad2f on macOS.

Tree-SHA512: 1418ce3c120c08e5ec3e7a7a063572a24402ce0ec541bd4adc21f61d60c4e86b711e82e940ebf5f0445ab861f89c146c2a2e7990fb52bed2c65fc199a1981f71
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#16122: gui: Enable console line edit on setClientModel
a1f23d0 
2d8ad2f gui: Enable console line edit on setClientModel (João Barbosa)

Pull request description:

  Make console line edit disable by default, and only enable once `RPCConsole::setClientModel` is called.

  Fixes bitcoin#16119.

ACKs for commit 2d8ad2:
  fanquake:
    tACK bitcoin@2d8ad2f on macOS.

Tree-SHA512: 1418ce3c120c08e5ec3e7a7a063572a24402ce0ec541bd4adc21f61d60c4e86b711e82e940ebf5f0445ab861f89c146c2a2e7990fb52bed2c65fc199a1981f71
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#16122: gui: Enable console line edit on setClientModel
a8e0b65 
2d8ad2f gui: Enable console line edit on setClientModel (João Barbosa)

Pull request description:

  Make console line edit disable by default, and only enable once `RPCConsole::setClientModel` is called.

  Fixes bitcoin#16119.

ACKs for commit 2d8ad2:
  fanquake:
    tACK bitcoin@2d8ad2f on macOS.

Tree-SHA512: 1418ce3c120c08e5ec3e7a7a063572a24402ce0ec541bd4adc21f61d60c4e86b711e82e940ebf5f0445ab861f89c146c2a2e7990fb52bed2c65fc199a1981f71
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#16122: gui: Enable console line edit on setClientModel
e6a0226 
2d8ad2f gui: Enable console line edit on setClientModel (João Barbosa)

Pull request description:

  Make console line edit disable by default, and only enable once `RPCConsole::setClientModel` is called.

  Fixes bitcoin#16119.

ACKs for commit 2d8ad2:
  fanquake:
    tACK bitcoin@2d8ad2f on macOS.

Tree-SHA512: 1418ce3c120c08e5ec3e7a7a063572a24402ce0ec541bd4adc21f61d60c4e86b711e82e940ebf5f0445ab861f89c146c2a2e7990fb52bed2c65fc199a1981f71
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#16122: gui: Enable console line edit on setClientModel
8500950 
2d8ad2f gui: Enable console line edit on setClientModel (João Barbosa)

Pull request description:

  Make console line edit disable by default, and only enable once `RPCConsole::setClientModel` is called.

  Fixes bitcoin#16119.

ACKs for commit 2d8ad2:
  fanquake:
    tACK bitcoin@2d8ad2f on macOS.

Tree-SHA512: 1418ce3c120c08e5ec3e7a7a063572a24402ce0ec541bd4adc21f61d60c4e86b711e82e940ebf5f0445ab861f89c146c2a2e7990fb52bed2c65fc199a1981f71
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#16122: gui: Enable console line edit on setClientModel
e55a34e 
2d8ad2f gui: Enable console line edit on setClientModel (João Barbosa)

Pull request description:

  Make console line edit disable by default, and only enable once `RPCConsole::setClientModel` is called.

  Fixes bitcoin#16119.

ACKs for commit 2d8ad2:
  fanquake:
    tACK bitcoin@2d8ad2f on macOS.

Tree-SHA512: 1418ce3c120c08e5ec3e7a7a063572a24402ce0ec541bd4adc21f61d60c4e86b711e82e940ebf5f0445ab861f89c146c2a2e7990fb52bed2c65fc199a1981f71
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this issue Jul 12, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#16122: gui: Enable console line edit on setClientModel
50f8552 
2d8ad2f gui: Enable console line edit on setClientModel (João Barbosa)

Pull request description:

  Make console line edit disable by default, and only enable once `RPCConsole::setClientModel` is called.

  Fixes bitcoin#16119.

ACKs for commit 2d8ad2:
  fanquake:
    tACK bitcoin@2d8ad2f on macOS.

Tree-SHA512: 1418ce3c120c08e5ec3e7a7a063572a24402ce0ec541bd4adc21f61d60c4e86b711e82e940ebf5f0445ab861f89c146c2a2e7990fb52bed2c65fc199a1981f71
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
gades pushed a commit to cosanta/cosanta-core that referenced this issue May 9, 2022
@laanwj @gades
Merge bitcoin#16122: gui: Enable console line edit on setClientModel
4687711 
2d8ad2f gui: Enable console line edit on setClientModel (João Barbosa)

Pull request description:

  Make console line edit disable by default, and only enable once `RPCConsole::setClientModel` is called.

  Fixes bitcoin#16119.

ACKs for commit 2d8ad2:
  fanquake:
    tACK bitcoin@2d8ad2f on macOS.

Tree-SHA512: 1418ce3c120c08e5ec3e7a7a063572a24402ce0ec541bd4adc21f61d60c4e86b711e82e940ebf5f0445ab861f89c146c2a2e7990fb52bed2c65fc199a1981f71
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gui: Enable console line edit on setClientModel promag/bitcoin
1 participant
@fanquake