Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Releases to Github #3224

Closed
super3 opened this issue Nov 8, 2013 · 14 comments
Closed

Move Releases to Github #3224

super3 opened this issue Nov 8, 2013 · 14 comments
Labels

Comments

@super3
Copy link
Contributor

super3 commented Nov 8, 2013

Just wanted to raise some discussion. Is it possible that we could transition our releases to Github.

I think it makes sense to consolidate releases here both for convenience and other reasons. But then again there might be some reasons for continuing to use sourceforge that I might not be aware of.

@laanwj
Copy link
Member

laanwj commented Nov 9, 2013

An added advantage of switching to github for releases would be https downloads.
I don't really see a drawback.

@luke-jr
Copy link
Member

luke-jr commented Nov 9, 2013

I think we'd lose download statistics?

@super3
Copy link
Contributor Author

super3 commented Nov 9, 2013

I'd trade that for simplicity and security. Think that is not really important anymore since we have a handful of alternate wallets too. I just pinged @github to see if download stats are possible.

@laanwj
Copy link
Member

laanwj commented Nov 9, 2013

@luke-jr Looks like there are download statistics on releases posted to github (in contrast to "source tarballs"):

https://github.com/jhclark/multeval/downloads

@gavinandresen
Copy link
Contributor

Only reason we were still at SourceForge for downloads was because github wasn't supporting big binary downloads, switching to github for the 0.9 release sounds like a fine idea to me.

@laanwj
Copy link
Member

laanwj commented Nov 9, 2013

Agreed @gavinandresen . Here the process of creating github releases is described, seems pretty straightforward: https://github.com/blog/1547-release-your-software

I did hear there are some limits with regard to file sizes and total storage, but I can't find definitive numbers, and as the releases feature is brand new they don't appear to have updated their faq (https://help.github.com/articles/what-is-my-disk-quota) yet.

@luke-jr
Copy link
Member

luke-jr commented Nov 9, 2013

Did GitHub re-introduce downloads? Last I heard, they were retiring them and they'd be disabled entirely at some future time...

@super3
Copy link
Contributor Author

super3 commented Nov 9, 2013

@luke-jr Yeah they depreciated downloads a while back, but recently they introduced releases which is what @laanwj and I linked to.

@gmaxwell
Copy link
Contributor

gmaxwell commented Nov 9, 2013

Seems like a no-brainer improvement if github really brought this stuff back. (people trusting a random third party's SSL for this is really concerning— they should be checking the signatures provided by the package, but I doubt it could make anything worse at this point).

(Though I do wonder when we're going to have hosts become uncomfortable with the size of the bounty we're creating for hacking their services…)

@laanwj
Copy link
Member

laanwj commented Nov 9, 2013

The problem is that it's pretty hard for users that are not used to GPG to check the current signatures. I suppose we could package gitian downloader but that won't help initial downloaders.

Both Windows and MacOSX provide ways to sign downloaded packages/executables, maybe we should look into that. Though I remember that the issue was deterministic gitian builds :/

And it's a pity .tar doesn't have signature support or we could do the same for Linux (.zip files can be signed using a manifest, but as decompression tools don't really check this by default it's kind of pointless).

In any case, indeed github won't make this problem worse, it doesn't matter whether we trust github or sourceforge in this regard...

@laanwj
Copy link
Member

laanwj commented Nov 11, 2013

Releasing on github could also solve #2476 (no separate source tarball download available) as github automatically packs up the state of the tree when generating a release.

@super3
Copy link
Contributor Author

super3 commented Nov 11, 2013

Ok. Well I guess we will do this for 0.9 then. If we encounter any unseen problems, we can just fallback to Sourceforge. Should we also post the previous releases on Github as well, or just post 0.9?

@DavidAJohnston
Copy link

I'd be in a favor of posting previous releases to Github for consistency sake, if there aren't any technical reasons not to.

@laanwj
Copy link
Member

laanwj commented May 2, 2014

We moved away from sourceforge, but to hosting the executables directly on bitcoin.org instead of github. Closing this.

@laanwj laanwj closed this as completed May 2, 2014
Bushstar pushed a commit to Bushstar/omnicore that referenced this issue Apr 8, 2020
This should make code a little bit cleaner, should be no changes in the actual behaviour: non-members do not sleep already due to `sleepTime` being negative for them and `phaseTime = 0` does the same on regtest but for everyone.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants