Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing very tiny font in the Debug console tab #7017

Closed
ptschip opened this issue Nov 14, 2015 · 25 comments · Fixed by #7364
Closed

Showing very tiny font in the Debug console tab #7017

ptschip opened this issue Nov 14, 2015 · 25 comments · Fixed by #7364
Labels

Comments

@ptschip
Copy link
Contributor

ptschip commented Nov 14, 2015

on Windows 7, 32bit

consoletab

@maflcko
Copy link
Member

maflcko commented Nov 14, 2015

Someone should revert 268b79e ...

@jonasschnelli
Copy link
Contributor

Thanks @ptschip for reporting. At first sight, i agree, it's small or lets say smaller then before. But if I compare it with other text elements like "Information" (tab), it looks reasonable.

Will compare font sized on windows within the next days.

@maflcko
Copy link
Member

maflcko commented Nov 18, 2015

it's small or lets say smaller than before

It's about 95% of the previous size ( 268b79e ). The reason this looks so tiny is that the windows monospace font is more wide than tall.

@ptschip
Copy link
Contributor Author

ptschip commented Nov 18, 2015

Size aside, why isn't it the same font as in the other tabs? The other
tabs look like Helvetica and only in this tab it's using some other font
which makes it only harder to read.

On 18/11/2015 4:23 AM, MarcoFalke wrote:

it's small or lets say smaller than before

It's about 95% of the previous size ( 268b79e
268b79e
). The reason this looks so tiny is that the windows monospace font is
more wide than tall.


Reply to this email directly or view it on GitHub
#7017 (comment).

@jonasschnelli
Copy link
Contributor

@ptschip This was changed in #6864. RPC output should use a fixed-pitch font (line in a terminal) for best readability.
Do you think it's harder to read because of the fixed-pitch font or because of the size?

@ptschip
Copy link
Contributor Author

ptschip commented Nov 18, 2015

@jonasschnelli It's the font style that is hard to read. Fixed pitch is fine when it's bigger but when it's small I find the edges of each letter start to blurr and I have to make more effort to view it especially on a 15" screen or less. With Helvetica you don't have that problem, it has clear edges.

@jonasschnelli
Copy link
Contributor

I agree that this is suboptimal. It feels like, that the terminals font and size is a matter of taste (and also depending on what OS is used). A nice solution would be to allow changing the font and size over the GUI settings.

@ptschip
Copy link
Contributor Author

ptschip commented Nov 18, 2015

@jonasschnelli Yes, I agree, it would be great if we could select our own font type and size. With all the different sized terminals and differences in vision, personal taste etc, it's hard to find a one size fits all approach.

@ptschip
Copy link
Contributor Author

ptschip commented Nov 18, 2015

@jonasschnelli Feel free to close this issue if it's not something that needs fixing but rather, requires an enhancement.

@jonasschnelli
Copy link
Contributor

Lets keep it open for now because other users might also find this problematic and i'd like to get more feedback for this.

@maflcko
Copy link
Member

maflcko commented Nov 18, 2015

Agree with @jonasschnelli to leave this open. The windows font really looks odd. On OSX (and linux) it looks much better.

@ptschip
Copy link
Contributor Author

ptschip commented Nov 18, 2015

you'll get no argument from me...

On 18/11/2015 9:03 AM, MarcoFalke wrote:

Agree with @jonasschnelli https://github.com/jonasschnelli to leave
this open. The windows font really looks odd. On OSX (and linux) it
looks much better.


Reply to this email directly or view it on GitHub
#7017 (comment).

@laanwj
Copy link
Member

laanwj commented Nov 20, 2015

As I said before #6864, I think it would have been better to stick with proportional font. Getting monospace fonts consistent on all platforms turns out, again, to be a time sink.

@maflcko
Copy link
Member

maflcko commented Dec 14, 2015

@jonasschnelli suggested to bundle a monospace font so we get the same flavor across platforms. I start liking this idea but I haven't yet found a suitable MIT/PD monospace font.

@jonasschnelli
Copy link
Contributor

Not sure if bundling a font for this purpose is a good solution. I would recommend that we add a feature that allows to switch/choose a custom font (over http://doc.qt.io/qt-4.8/qfontdialog.html). Either over the setting panel or – hidden as "expert features" – over a context menu of the console textview.

@luke-jr
Copy link
Member

luke-jr commented Dec 14, 2015

@laanwj
Copy link
Member

laanwj commented Dec 14, 2015

IMO bundling a font is overkill. This is getting out of hand, the debug console is just a developer feature, it doesn't need all this design effort.

@veqtrus
Copy link
Contributor

veqtrus commented Jan 17, 2016

This is still a problem in 0.12rc1.

image

@maflcko
Copy link
Member

maflcko commented Jan 17, 2016

Too many users complain about this. Let's make the workaround a bit more dirty because no one liked it in the first place. Please see #7364.

@laanwj
Copy link
Member

laanwj commented Jan 18, 2016

I still think we should simply revert to a proportional font. This is getting crazy.

@jonasschnelli
Copy link
Contributor

Agree with @laanwj.

@maflcko
Copy link
Member

maflcko commented Jan 18, 2016

Ok with me but I'd rather schedule this after the 0.12.0 release. #7364 as a Windows only fix for 0.12.0 is ugly but acceptable?

@jonasschnelli
Copy link
Contributor

I think we should not introduce a monospace font in 0.12 and remove it in 0.12.1 (or 0.13). IMO best solution would be to revert and go back to the original behavior. What was the original issue to switch over to the monospace font?

@maflcko
Copy link
Member

maflcko commented Jan 18, 2016

Your pretty-print pull "introduced" the issue ;)

@laanwj
Copy link
Member

laanwj commented Jan 18, 2016

The pretty-printing looked somewhat better with monospaced font. However, getting one font to work well over platforms already seems to be problematic. Every time you think you got it right, some new issue turns up (e.g. #7341). So let alone two...

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants