[qt] Use monospace font #6864

maflcko · 2015-10-21T10:58:18Z

This uses #4228 to find a monospace font for the qt rpcconsole.

(This replaces, thus closes #6781.)

laanwj · 2015-10-21T11:12:25Z

src/qt/rpcconsole.cpp

@@ -463,13 +463,15 @@ void RPCConsole::clear()

    // Set default style sheet
    ui->messagesWidget->document()->setDefaultStyleSheet(
+        QString::fromStdString(strprintf(


Please use Qt's formatting, instead of strprintf. e.g.

QString("....\1...." ).arg(...)

jonasschnelli · 2015-10-21T13:19:10Z

Binaries are here: https://bitcoin.jonasschnelli.ch/pulls/6864/

Would be good if we get some screenshot from HiDPI Ubuntu and retina OSX.

Diapolo · 2015-10-21T19:56:16Z

src/qt/rpcconsole.cpp

                "td.cmd-request { color: #006060; } "
                "td.cmd-error { color: red; } "
                "b { color: #006060; } "
-                );
-
+            ).arg(QFont("Monospace").pointSize() * 4 / 5) // 0.8 em


QFont("Monospace").pointSize() * 4 / 5 is a float, so should this also include a call to QString & QString::setNum(float n, char format = 'g', int precision = 6)?

Also not sure if relevant, but as per the docs .pointSize():
Returns the point size of the font. Returns -1 if the font size was specified in pixels.

Perhaps you also could exchange Monospace with QFont::Monospace... I didn't try the code btw.

Thanks, I have alrady replaced the code with a version that should work on all platforms (and maybe even HiDPI).

laanwj · 2015-10-22T15:49:27Z

Looks good here. There used to be problems with (absurdly large) font size in Ubuntu with previous monospace patches, but I'm not seeing that now.

Can't test hidpi though...

jonasschnelli · 2015-10-22T18:32:57Z

Kicked the build server,... new builds should be available within the next 30mins: https://bitcoin.jonasschnelli.ch/pulls/6864/
(reminds me to finally complete my IRC-gitian-build-bot and collect some devs pub keys to allow dev-build-sig-checks)

jonasschnelli · 2015-10-22T19:31:44Z

Ubuntu/Linux HiDPI looks ugly,.. but not related to this PR.
Fine for me:

Crash on OSX:

jonasschnelli$ ~/Desktop/bitcoin-qt --regtest
Assertion failed: (fixedFontInfo.fixedPitch()), function clear, file qt/rpcconsole.cpp, line 470.

maflcko · 2015-10-22T20:35:10Z

To properly support HiDPI, I think we need to do the switch to qt5.

Windows works now, as well. (Courier New 10pt)

laanwj · 2015-10-23T08:34:51Z

To properly support HiDPI, I think we need to do the switch to qt5.

Supporting HiDPI is not a requirement for Qt4. All the distribution binaries are built with Qt5. We still support Qt4 in the same way as websites support IE6, e.g. bare-bones: functionality must work but it is allowed to be ugly.

luke-jr · 2015-10-23T08:40:26Z

Uh, Qt4 should remain a fully-supported platform until KDE has finished switching away from it... (this case would be an exception IMO since Qt4 itself lacks HiDPI support.)

fanquake · 2015-10-24T02:05:49Z

@jonasschnelli Your OS X binaries are crashing for me, are you having any issue with them?

jonasschnelli · 2015-10-24T08:41:17Z

@fanquake: the crash is related to the PR. Monospace is not available on Mac (or something similar).

jonasschnelli · 2015-10-24T09:12:23Z

@fanquake: you probably picked an old build. Always check the git tip. Just re-started the build of the PR.

maflcko · 2015-10-24T17:47:56Z

This is ready for review now.

@fanquake and reviewers: Please use jonasschnelli's binaries for debug (send me stdout when no monospace font is found).

The code in this PR has the debug to stdout removed in 1d15e0e762cdfa83d4f98d96e532e35c0f8f6cf4 , was squashed and force pushed.

dexX7 · 2015-10-24T20:58:19Z

On the first glimpse (general UI, address manager, debug console) it looks good on Win10:

jonasschnelli · 2015-10-26T16:17:53Z

I don't have a fixed space font on OSX. Also the font is relatively small now.

This PR:

Current ~Master:

dexX7 · 2015-10-26T21:39:05Z

Also the font is relatively small now.

In this case I wouldn't further increase the size, because then it probably gets too big on the other OS, but I agree, it looks too small.

While this doesn't seem to be an issue with fixed space font (especially since it's not available on OS X, as it seems), it may be worth to consider using a relative size based on a common, well sized font as reference, i.e. instead of using 10pt:

retrieve actual font size of "reference font"
use the reference size as size for the console font (whatever font it is)

maflcko · 2015-10-27T08:09:30Z

@dexX7 If there was a "reference font", you could as well just not set the pt size at all, I guess. Let's try this?

maflcko · 2015-10-29T17:35:20Z

If no one complains, this should be merged.

More screenshots:

Windows

nightly
this PR

Fedora

nightly
this PR

Fedora

8daffe2
28313b8

laanwj · 2015-11-02T03:41:38Z

Still has a crazily big font on Ubuntu. Tending towards closing this, it's not worth the hassle.

maflcko · 2015-11-02T13:09:05Z

@laanwj Unfortunately I can not reproduce the issue you mentioned. I did a fresh install of Ubuntu 15.10 and got the results below. Also, @dexX7 could not find an issue for Ubuntu. Maybe you changed the default settings for the system fonts accidentally?

$ gsettings list-recursively  org.gnome.desktop.interface|egrep "(font|text-scaling)"
org.gnome.desktop.interface monospace-font-name 'Ubuntu Mono 13'
org.gnome.desktop.interface text-scaling-factor 1.0
org.gnome.desktop.interface font-name 'Ubuntu 11'
org.gnome.desktop.interface document-font-name 'Sans 11'

Ubuntu

Nightly

This PR

OSX

(screenshots from @jonasschnelli)

Nightly

- This PR

laanwj · 2015-11-02T13:24:46Z

Looks like it's the same:

$ gsettings list-recursively  org.gnome.desktop.interface|egrep "(font|text-scaling)"
org.gnome.desktop.interface monospace-font-name 'Ubuntu Mono 13'
org.gnome.desktop.interface text-scaling-factor 1.0
org.gnome.desktop.interface font-name 'Ubuntu 11'
org.gnome.desktop.interface document-font-name 'Sans 11'

Have tried it on two systems. I'm using Ubuntu 14.04 and Qt5. I compile using the system's Qt5 library and am not using depends.
It is curious that 15.10 does display it in a normal font so maybe it's an Ubuntu issue that was fixed but not in LTS.

Edit: tried with Qt4, same problem.
I'll try with a 15.10 VM.

laanwj · 2015-11-02T15:48:32Z

15.10 - fresh install. What am I doing wrong?

Before:

After:

maflcko · 2015-11-02T15:52:53Z

@laanwj Thank you for trying this. Would you mind to edit your posts to include the screenshots for the build without this PR?

laanwj · 2015-11-02T16:12:48Z

Added for the 15.10 VM above: for the others the effect is exactly the same, except for the code changes as they were at the beginning of this pull request, there the fixed and proportional font were almost the same size.

maflcko · 2015-11-02T17:23:22Z

[...] beginning of this pull request, there the fixed and proportional font were almost the same size.

Yes, it was "hard-coded" at 10pt but @jonasschnelli complained 10pt won't work in OS X, IIRC.

laanwj · 2015-11-03T06:34:16Z

So it looks like Ubuntu consistently specifies a huge monospace default font. I guess that's simply the Ubuntu Mono 13 from qsettings? That's kind of annoying. I just never noticed on other programs - there are only few programs that use monospace besides the terminal, which seems to choose its own.

The only thing I don't understand is that you don't get the same.

jonasschnelli · 2015-11-03T09:12:46Z

Tested ACK.

Ubuntu:

Ubuntu HiDPI:

OSX:

jonasschnelli · 2015-11-03T09:13:57Z

Maybe someone can test this over a Qt4 build? (@luke-jr)?

laanwj · 2015-11-03T11:37:58Z

I've already tested Qt4. Works OK.

maflcko · 2015-11-03T11:44:57Z

I guess that's simply the Ubuntu Mono 13 from qsettings?

No, qt selects "DejaVu Sans Mono 12", and I set the size to QFontInfo(QFont()).pointSize(), which is less than 12pt (e.g. 10pt or 9pt) but equal to the font height we had before for the rpc console.

the terminal, which seems to choose its own.

No, terminal chooses the default "Ubuntu Mono 13".

The only thing I don't understand is that you don't get the same.

Maybe, there is a difference when you use the gitian builds by jonasschnelli ( 9pt) and your own build (10pt). Probably, because gitian uses qt5 and you are using qt4?

@laanwj The monospace font appears larger than the non monospace font because it consumes way more horizontal space. The only thing I can do here is to scale the font's height by a hard coded factor (like ~95%).

I have added a commit to do just that. If a constant factor can't fix your concern (exact value up for bike shedding), you are welcome to close this PR.

laanwj · 2015-11-03T11:47:58Z

Maybe, there is a difference when you use the gitian builds by jonasschnelli ( 9pt)

Right - the gitian build by jonasschelli uses static qt from the depends system, I build against the system's Qt5 library (this is what the Ubuntu PPA does).
Fine with a fixed factor, seems an Ubuntu problem, don't want to bikeshed this further either.

maflcko · 2015-11-03T12:44:54Z

As OS X was the only one getting it right, I expect the constant factor makes the font look smaller now on OS X. Hopefully such that it is still acceptable.

jonasschnelli · 2015-11-03T13:22:18Z

I think this is a improvement over the current version and the PR is pretty clean. Minor font size differences are an upstream issue IMO and still result in a adequate quality. Also the indent formatting increase readability.

maflcko · 2015-11-03T13:30:17Z

@jonasschnelli So you are against 268b79e?

jonasschnelli · 2015-11-03T13:38:09Z

ACK 268b79e

luke-jr · 2015-11-03T18:33:41Z

src/qt/rpcconsole.cpp

@@ -462,13 +462,19 @@ void RPCConsole::clear()
    }

    // Set default style sheet
+    QFontInfo fixedFontInfo(GUIUtil::fixedPitchFont());
+    // Try to make fixed font adequately large on different OS
+    QString ptSize = QString("%1pt").arg(QFontInfo(QFont()).pointSize() * 8.5 / 9);


This seems weird. Why is this not simply using fixedFontInfo.pointSize()?

I also preferred to non-* 8.5 / 9 solution. But i have ACKed this solution because it might slightly reduce the size of mostly-oversized monospace fonts. But a *0.95 instead a * 8.5/9 would be cleaner, right.

@luke-jr fixedFontInfo.pointSize() is 12, so way too large. Also, people were requesting that the fixed pitch font is exactly the same size as the previous default font.

@jonasschnelli QFontInfo(QFont()).pointSize() is 9, often. So we get a 8.5pt in this case instead of a longer float.

@MarcoFalke If fixedFontInfo.pointSize() is wrong, then that should be fixed instead. If people merely don't have their systems configured correctly, that isn't a problem we should try to workaround in the application.

@luke-jr Maybe you could do something like http://stackoverflow.com/a/12179548 to read the system default font. But I am not planning to do this within this PR, as this will likely change the text for the whole GUI.

I see only three options for this PR:

Close

Merge 28313b8 (Monospace with "old" text-height)

Merge 268b79e (Same as above with constant scale factor)

luke-jr · 2015-11-03T18:35:09Z

268b79e looks fine to me, but it can be improved by using the fixed font for the input as well. This nit should at least get a comment explaining the rationale. Also, next time, please do the rename (bitcoinAddressFont -> fixedPitchFont) in a dedicated commit.

laanwj · 2015-11-04T12:05:43Z

This is already bikeshedded to death, please let's not start another round.
I personally couldn't care less if the console font is monospace or proportional but some people want this and it seems to work acceptably, so I'm going to merge it now.

268b79e [qt] rpcconsole: Scale monospace font to 95% (MarcoFalke) 28313b8 [qt] Use fixed pitch font for the rpc console (MarcoFalke)

laanwj reviewed Oct 21, 2015
View reviewed changes

laanwj added the GUI label Oct 21, 2015

maflcko force-pushed the MarcoFalke-2015-qtMonospace branch from cb42034 to 98c66cd Compare October 21, 2015 11:25

Diapolo reviewed Oct 21, 2015
View reviewed changes

maflcko force-pushed the MarcoFalke-2015-qtMonospace branch from d0e4399 to 89a0bf8 Compare October 22, 2015 11:35

maflcko force-pushed the MarcoFalke-2015-qtMonospace branch 2 times, most recently from 53a9779 to 2cdd8a1 Compare October 23, 2015 07:03

maflcko force-pushed the MarcoFalke-2015-qtMonospace branch from 1d15e0e to e969ffb Compare October 24, 2015 17:41

laanwj mentioned this pull request Oct 26, 2015

[QT] pretty print (indent) multiline html output #6781

Closed

maflcko force-pushed the MarcoFalke-2015-qtMonospace branch from e969ffb to 0e0b8ba Compare October 27, 2015 08:03

maflcko force-pushed the MarcoFalke-2015-qtMonospace branch from 0e0b8ba to 2fc054c Compare October 27, 2015 08:16

[qt] rpcconsole: Scale monospace font to 95%

268b79e

luke-jr reviewed Nov 3, 2015
View reviewed changes

laanwj merged commit 268b79e into bitcoin:master Nov 4, 2015

laanwj added a commit that referenced this pull request Nov 4, 2015

Merge pull request #6864

c702521

268b79e [qt] rpcconsole: Scale monospace font to 95% (MarcoFalke) 28313b8 [qt] Use fixed pitch font for the rpc console (MarcoFalke)

maflcko deleted the MarcoFalke-2015-qtMonospace branch November 4, 2015 12:08

jonasschnelli mentioned this pull request Nov 18, 2015

Showing very tiny font in the Debug console tab #7017

Closed

maflcko mentioned this pull request Dec 17, 2015

qt5: Use the fixed font the system recommends #7214

Merged

maflcko mentioned this pull request Jan 17, 2016

[qt] Windows: Make rpcconsole monospace font larger #7364

Merged

promag mentioned this pull request Mar 11, 2020

gui: fix font inconsistency on send coins form #18313

Closed

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

[qt] Use monospace font #6864

[qt] Use monospace font #6864

Conversation

maflcko commented Oct 21, 2015

Choose a reason for hiding this comment

jonasschnelli commented Oct 21, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

laanwj commented Oct 22, 2015

jonasschnelli commented Oct 22, 2015

jonasschnelli commented Oct 22, 2015

maflcko commented Oct 22, 2015

laanwj commented Oct 23, 2015

luke-jr commented Oct 23, 2015

fanquake commented Oct 24, 2015

jonasschnelli commented Oct 24, 2015

jonasschnelli commented Oct 24, 2015

maflcko commented Oct 24, 2015

dexX7 commented Oct 24, 2015

jonasschnelli commented Oct 26, 2015

dexX7 commented Oct 26, 2015

maflcko commented Oct 27, 2015

maflcko commented Oct 29, 2015

Windows

Fedora

Fedora

laanwj commented Nov 2, 2015

maflcko commented Nov 2, 2015

Ubuntu

OSX

laanwj commented Nov 2, 2015

laanwj commented Nov 2, 2015

maflcko commented Nov 2, 2015

laanwj commented Nov 2, 2015

maflcko commented Nov 2, 2015

laanwj commented Nov 3, 2015

jonasschnelli commented Nov 3, 2015

jonasschnelli commented Nov 3, 2015

laanwj commented Nov 3, 2015

maflcko commented Nov 3, 2015

laanwj commented Nov 3, 2015

maflcko commented Nov 3, 2015

jonasschnelli commented Nov 3, 2015

maflcko commented Nov 3, 2015

jonasschnelli commented Nov 3, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luke-jr commented Nov 3, 2015

laanwj commented Nov 4, 2015