Qt: Network Watch tool #9849
Qt: Network Watch tool #9849
Conversation
luke-jr
force-pushed
the
gui_netwatch
branch
from
585bf3c to
563ec9e
Compare
|
This is how it looks like here on testnet:
|
|
Thanks. Will review. |
luke-jr
force-pushed
the
gui_netwatch
branch
2 times, most recently
from
bc3e9fd to
9019229
Compare
|
Running this PR (built over gitian: https://bitcoin.jonasschnelli.ch/build/54) makes Bitcoin-Qt and also the rest of my apps almost unusable. Had to force kill the process. |
luke-jr
force-pushed
the
gui_netwatch
branch
2 times, most recently
from
aee0ac0 to
bbbef18
Compare
|
Concept ACK, I like having this, though we have to be sure that there is no performance impact when the monitor is not running, and as little as possible when it is. |
|
The code is (already) disabled until the first time it is opened. |
|
Oops, had rebased onto 0.17 instead of master. Rebased for real this time. |
| *((meta_t*)data) |= (3 << 30); | ||
| } | ||
|
|
||
| class NetWatchValidationInterface final : public CValidationInterface { |
There was a problem hiding this comment.
Should use/extend interfaces::Node instead?
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
src/qt/netwatch.cpp
Outdated
| NetWatchLogModel& model; | ||
|
|
||
| public: | ||
| NetWatchValidationInterface(NetWatchLogModel& model_in) : model(model_in) {} |
There was a problem hiding this comment.
Should be explicit? :-)
src/qt/netwatch.h
Outdated
| NWLMH_VALUE, | ||
| }; | ||
|
|
||
| NetWatchLogModel(QWidget *parent); |
There was a problem hiding this comment.
Should be made explicit?
| --m_logskip; | ||
| } else { | ||
| // Haven't filled up yet, so just push_back | ||
| assert(!m_logpos); |
There was a problem hiding this comment.
I see this assertion on Windows in testing, haven't take a look at the code.
…eing unregistered
luke-jr
force-pushed
the
gui_netwatch
branch
from
654f66d to
04e2b37
Compare
Simple realtime log of p2p network activity (blocks and transactions only) - Doesn't begin logging until opened; limited to 0x400 entries (outputs) - Automatically scrolls if left at the bottom of the log; maintains position if left elsewhere - Memory-efficient circular buffer; CTransaction references become weak after they're 0x200 entries back in the log - Search function that selects all matching log entries, including ongoing
luke-jr
force-pushed
the
gui_netwatch
branch
from
04e2b37 to
ba6074b
Compare
| ptx_old->~CTransactionRef(); | ||
| CTransactionWeakref * const ptx_new = get<CTransactionWeakref>(); | ||
| new (ptx_new) CTransactionWeakref(tx); | ||
| *((meta_t*)m_data) |= (3 << 30); |
| Needs rebase |
|
As this PR has been inactive for a long time, I'm closing this (but marking "up for grabs"). |
|
Moved to bitcoin-core/gui#444 |
Simple realtime log of p2p network activity (blocks and transactions only)