Fix gitian build after libzmq bump #11981

theuni · 2017-12-21T23:04:37Z

Broken gitian builds were introduced with #9254. Big thanks to @jonasschnelli for narrowing down the bisection.

This is broken for a number of reasons, including:

g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy.
another stdlib (libc++ for example) may be in use

This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use

jonasschnelli · 2017-12-21T23:38:25Z

Let's see
Just started https://bitcoin.jonasschnelli.ch/build/431

We should probably always test depends changes with a gitian build.

fanquake · 2017-12-22T01:25:04Z

I'm wondering, before we fix this, should we update to 4.2.3 and see if anything else breaks?
It was only recently released, which is why it wasn't in #9254, and basically includes a years worth of bug fixes, which I think would be good to get in.

~~Note: We'd want to look at patching for OpenBSD: zeromq/libzmq@22b57f6~~

theuni · 2017-12-22T02:01:13Z

Sure, though I checked upstream master before creating the patch here, in case there was something to backport (and also to file a bug report, which I haven't done yet).

So this fix should work with 4.2.3. as well.

Re OpenBSD, we don't currently build releases, so no need to worry about that patch.

jonasschnelli · 2017-12-22T06:33:25Z

Fixed the gitian build (https://bitcoin.jonasschnelli.ch/build/431).
Tested ACK a6365c5

laanwj · 2017-12-22T08:22:15Z

This one is extremely sneaky. Why the hell would they do this?
utACK a6365c5

Re OpenBSD, we don't currently build releases, so no need to worry about that patch.

Indeed, and zeromq package is easy to install from the ports/pkg_add system for people building from source.

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with #9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

13a399a depends: patch pthread_set_name_np out of zeromq (Cory Fields) 8f79226 depends: zeromq 4.2.3 (fanquake) Pull request description: This is a followup to #9254 and #11981. Zeromq 4.2.3 was released just after #9254 was merged, and contains a years worth of improvements/bug fixes. See the release notes [here](https://github.com/zeromq/libzmq/releases/tag/v4.2.3). Todo: - [ ] Add zeromq-4.2.3.tar.gz to /depends-sources on bitcoincore.org - [ ] Verify gitian builds are still OK - [ ] Check: zeromq/libzmq#2787 Tree-SHA512: 85e06f47be3e1fdedcee50ce90e3391d69df2ea1c167472ffc3126d8970d418eb75141b970e422eb2fda9a8cad00e6ba5b36afa53565171a9ebaa152a9dc9b60

Summary: ``` Update depends ZeroMQ to 4.2.2, the release notes are available here. We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release). --without-documentation is deprecated and has been replaced with --without-docs. --disable-perf disables building performance measuring tools, which are enabled by default, see the libzmq configure.ac. Updated dependencies.md. --disable-curve-keygen disable building the curve key generation tool. See here. ``` Backport of core [[bitcoin/bitcoin#9254 | PR9254]] and [[bitcoin/bitcoin#11981 | PR11981]] (related bugfix). Depends on D5577. Test Plan: Run the Gitian builds. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5574

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

13a399a depends: patch pthread_set_name_np out of zeromq (Cory Fields) 8f79226 depends: zeromq 4.2.3 (fanquake) Pull request description: This is a followup to bitcoin#9254 and bitcoin#11981. Zeromq 4.2.3 was released just after bitcoin#9254 was merged, and contains a years worth of improvements/bug fixes. See the release notes [here](https://github.com/zeromq/libzmq/releases/tag/v4.2.3). Todo: - [ ] Add zeromq-4.2.3.tar.gz to /depends-sources on bitcoincore.org - [ ] Verify gitian builds are still OK - [ ] Check: zeromq/libzmq#2787 Tree-SHA512: 85e06f47be3e1fdedcee50ce90e3391d69df2ea1c167472ffc3126d8970d418eb75141b970e422eb2fda9a8cad00e6ba5b36afa53565171a9ebaa152a9dc9b60 (cherry picked from commit 765a3eb) # Conflicts: # doc/dependencies.md

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

13a399a depends: patch pthread_set_name_np out of zeromq (Cory Fields) 8f79226 depends: zeromq 4.2.3 (fanquake) Pull request description: This is a followup to bitcoin#9254 and bitcoin#11981. Zeromq 4.2.3 was released just after bitcoin#9254 was merged, and contains a years worth of improvements/bug fixes. See the release notes [here](https://github.com/zeromq/libzmq/releases/tag/v4.2.3). Todo: - [ ] Add zeromq-4.2.3.tar.gz to /depends-sources on bitcoincore.org - [ ] Verify gitian builds are still OK - [ ] Check: zeromq/libzmq#2787 Tree-SHA512: 85e06f47be3e1fdedcee50ce90e3391d69df2ea1c167472ffc3126d8970d418eb75141b970e422eb2fda9a8cad00e6ba5b36afa53565171a9ebaa152a9dc9b60 (cherry picked from commit 765a3eb) # Conflicts: # doc/dependencies.md

Summary: ``` Update depends ZeroMQ to 4.2.2, the release notes are available here. We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release). --without-documentation is deprecated and has been replaced with --without-docs. --disable-perf disables building performance measuring tools, which are enabled by default, see the libzmq configure.ac. Updated dependencies.md. --disable-curve-keygen disable building the curve key generation tool. See here. ``` Backport of core [[bitcoin/bitcoin#9254 | PR9254]] and [[bitcoin/bitcoin#11981 | PR11981]] (related bugfix). Depends on D5577. Test Plan: Run the Gitian builds. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5574

fanquake added the Build system label Dec 22, 2017

laanwj merged commit a6365c5 into bitcoin:master Dec 22, 2017

fanquake mentioned this pull request Dec 22, 2017

[depends] zeromq 4.2.3 #11986

Merged

3 tasks

laanwj mentioned this pull request Jan 11, 2018

Gitian build glibc symbol compatibility issue #11935

Closed

sickpig mentioned this pull request Jun 5, 2018

[PORT] Depends cherries BitcoinUnlimited/BitcoinUnlimited#1120

Merged

fanquake mentioned this pull request Jul 1, 2018

[depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq api functions #13578

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix gitian build after libzmq bump #11981

Fix gitian build after libzmq bump #11981

theuni commented Dec 21, 2017

jonasschnelli commented Dec 21, 2017

fanquake commented Dec 22, 2017 •

edited

theuni commented Dec 22, 2017

jonasschnelli commented Dec 22, 2017

laanwj commented Dec 22, 2017

Fix gitian build after libzmq bump #11981

Fix gitian build after libzmq bump #11981

Conversation

theuni commented Dec 21, 2017

jonasschnelli commented Dec 21, 2017

fanquake commented Dec 22, 2017 • edited

theuni commented Dec 22, 2017

jonasschnelli commented Dec 22, 2017

laanwj commented Dec 22, 2017

fanquake commented Dec 22, 2017 •

edited