[depends] ZeroMQ 4.2.2 #9254

fanquake · 2016-12-01T04:52:57Z

Update depends ZeroMQ to 4.2.2, the release notes are available here.

We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release).

--without-documentation is deprecated and has been replaced with --without-docs.
--disable-perf disables building performance measuring tools, which are enabled by default, see the libzmq configure.ac.
Updated dependencies.md.
--disable-curve-keygen disable building the curve key generation tool. See here.

Can someone on windows test that this is still working correctly. Maybe @achow101 ?

jonasschnelli · 2016-12-01T07:53:00Z

Travis Windows (depends build) is failing.
I think you need to adopt the MinGW static patches instead of removing.

fanquake · 2016-12-02T03:04:27Z

The patches were only turning this line: AC_MSG_ERROR([Building static libraries is not supported under MinGW32]) into CPPFLAGS="-DZMQ_STATIC $CPPFLAGS" (in two steps, as we wanted to use the commits from upstream). The new configure.ac now contains both patches, see here, so I think this is a different issue. Will investigate shortly.

/usr/share/mingw-w64/include/netioapi.h:458:3: error: ‘SOCKADDR_INET’ has not been declared
   SOCKADDR_INET *BestSourceAddress
   ^
In file included from /usr/share/mingw-w64/include/iphlpapi.h:16:0,
                 from src/windows.hpp:58,
                 from src/precompiled.hpp:37,
                 from src/address.cpp:30:
/usr/share/mingw-w64/include/netioapi.h:585:9: error: ‘SOCKADDR_INET’ does not name a type
   const SOCKADDR_INET *SourceAddress
         ^
In file included from src/windows.hpp:58:0,
                 from src/precompiled.hpp:37,
                 from src/address.cpp:30:
/usr/share/mingw-w64/include/iphlpapi.h:147:5: error: ‘SOCKADDR_IN6’ does not name a type
     SOCKADDR_IN6 Ipv6Address;
     ^

fanquake · 2017-01-04T12:51:06Z

Pushed a commit to update to the latest point release (4.2.1), may also help with these issues.

laanwj · 2017-01-05T10:42:33Z

Still the SOCKADDR_INET issue on win32/64

laanwj · 2017-04-03T10:20:19Z

Seems this is blocked by an upstream issue?

TheBlueMatt · 2017-09-29T00:17:01Z

Has the issue been reported upstream? Any closer to resolving this one?

fanquake · 2017-10-06T02:37:50Z

@theuni Can you take a look here you have a chance? We discussed setting WINNT a while back.

fanquake · 2017-11-29T11:35:30Z

Added --disable-curve-keygen to our configure options. This option disables building the curve key generation tool, see the zeromq configure.ac.

theuni · 2017-11-29T17:25:34Z

Sure, utACK 126999d.

@achow101

126999d depends: fix zmq build with mingw < 4.0 (Cory Fields) 387879d [depends] ZeroMQ 4.2.2 (fanquake) Pull request description: Update depends ZeroMQ to 4.2.2, the release notes are available [here](https://github.com/zeromq/libzmq/releases). We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release). `--without-documentation` is deprecated and has been replaced with `--without-docs`. `--disable-perf` disables building performance measuring tools, which are enabled by default, see the libzmq [configure.ac](https://github.com/zeromq/libzmq/blob/master/configure.ac#L367). Updated dependencies.md. `--disable-curve-keygen` disable building the curve key generation tool. See [here](https://github.com/zeromq/libzmq/blob/master/configure.ac#L405). Can someone on windows test that this is still working correctly. Maybe @achow101 ? Tree-SHA512: c6c4b15f545b6de21648f05027b5500fca0e6b5b72e791ac9a0aa523c57f2feb5aae94e42531275dddd922e11e462a52f08be1118ba1629c3cae765b18e5d720

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with #9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

13a399a depends: patch pthread_set_name_np out of zeromq (Cory Fields) 8f79226 depends: zeromq 4.2.3 (fanquake) Pull request description: This is a followup to #9254 and #11981. Zeromq 4.2.3 was released just after #9254 was merged, and contains a years worth of improvements/bug fixes. See the release notes [here](https://github.com/zeromq/libzmq/releases/tag/v4.2.3). Todo: - [ ] Add zeromq-4.2.3.tar.gz to /depends-sources on bitcoincore.org - [ ] Verify gitian builds are still OK - [ ] Check: zeromq/libzmq#2787 Tree-SHA512: 85e06f47be3e1fdedcee50ce90e3391d69df2ea1c167472ffc3126d8970d418eb75141b970e422eb2fda9a8cad00e6ba5b36afa53565171a9ebaa152a9dc9b60

@achow101

126999d depends: fix zmq build with mingw < 4.0 (Cory Fields) 387879d [depends] ZeroMQ 4.2.2 (fanquake) Pull request description: Update depends ZeroMQ to 4.2.2, the release notes are available [here](https://github.com/zeromq/libzmq/releases). We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release). `--without-documentation` is deprecated and has been replaced with `--without-docs`. `--disable-perf` disables building performance measuring tools, which are enabled by default, see the libzmq [configure.ac](https://github.com/zeromq/libzmq/blob/master/configure.ac#L367). Updated dependencies.md. `--disable-curve-keygen` disable building the curve key generation tool. See [here](https://github.com/zeromq/libzmq/blob/master/configure.ac#L405). Can someone on windows test that this is still working correctly. Maybe @achow101 ? Tree-SHA512: c6c4b15f545b6de21648f05027b5500fca0e6b5b72e791ac9a0aa523c57f2feb5aae94e42531275dddd922e11e462a52f08be1118ba1629c3cae765b18e5d720

@achow101

126999d depends: fix zmq build with mingw < 4.0 (Cory Fields) 387879d [depends] ZeroMQ 4.2.2 (fanquake) Pull request description: Update depends ZeroMQ to 4.2.2, the release notes are available [here](https://github.com/zeromq/libzmq/releases). We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release). `--without-documentation` is deprecated and has been replaced with `--without-docs`. `--disable-perf` disables building performance measuring tools, which are enabled by default, see the libzmq [configure.ac](https://github.com/zeromq/libzmq/blob/master/configure.ac#L367). Updated dependencies.md. `--disable-curve-keygen` disable building the curve key generation tool. See [here](https://github.com/zeromq/libzmq/blob/master/configure.ac#L405). Can someone on windows test that this is still working correctly. Maybe @achow101 ? Tree-SHA512: c6c4b15f545b6de21648f05027b5500fca0e6b5b72e791ac9a0aa523c57f2feb5aae94e42531275dddd922e11e462a52f08be1118ba1629c3cae765b18e5d720

Summary: ``` Update depends ZeroMQ to 4.2.2, the release notes are available here. We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release). --without-documentation is deprecated and has been replaced with --without-docs. --disable-perf disables building performance measuring tools, which are enabled by default, see the libzmq configure.ac. Updated dependencies.md. --disable-curve-keygen disable building the curve key generation tool. See here. ``` Backport of core [[bitcoin/bitcoin#9254 | PR9254]] and [[bitcoin/bitcoin#11981 | PR11981]] (related bugfix). Depends on D5577. Test Plan: Run the Gitian builds. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5574

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

13a399a depends: patch pthread_set_name_np out of zeromq (Cory Fields) 8f79226 depends: zeromq 4.2.3 (fanquake) Pull request description: This is a followup to bitcoin#9254 and bitcoin#11981. Zeromq 4.2.3 was released just after bitcoin#9254 was merged, and contains a years worth of improvements/bug fixes. See the release notes [here](https://github.com/zeromq/libzmq/releases/tag/v4.2.3). Todo: - [ ] Add zeromq-4.2.3.tar.gz to /depends-sources on bitcoincore.org - [ ] Verify gitian builds are still OK - [ ] Check: zeromq/libzmq#2787 Tree-SHA512: 85e06f47be3e1fdedcee50ce90e3391d69df2ea1c167472ffc3126d8970d418eb75141b970e422eb2fda9a8cad00e6ba5b36afa53565171a9ebaa152a9dc9b60 (cherry picked from commit 765a3eb) # Conflicts: # doc/dependencies.md

Update ZeroMQ Includes changes cherry-picked from the following upstream PRs: - bitcoin/bitcoin#9254 - bitcoin/bitcoin#13578 - bitcoin/bitcoin#15844 - bitcoin/bitcoin#16370 - Only the ZeroMQ changes. - bitcoin/bitcoin#16949

13a399a depends: patch pthread_set_name_np out of zeromq (Cory Fields) 8f79226 depends: zeromq 4.2.3 (fanquake) Pull request description: This is a followup to bitcoin#9254 and bitcoin#11981. Zeromq 4.2.3 was released just after bitcoin#9254 was merged, and contains a years worth of improvements/bug fixes. See the release notes [here](https://github.com/zeromq/libzmq/releases/tag/v4.2.3). Todo: - [ ] Add zeromq-4.2.3.tar.gz to /depends-sources on bitcoincore.org - [ ] Verify gitian builds are still OK - [ ] Check: zeromq/libzmq#2787 Tree-SHA512: 85e06f47be3e1fdedcee50ce90e3391d69df2ea1c167472ffc3126d8970d418eb75141b970e422eb2fda9a8cad00e6ba5b36afa53565171a9ebaa152a9dc9b60 (cherry picked from commit 765a3eb) # Conflicts: # doc/dependencies.md

@achow101

126999d depends: fix zmq build with mingw < 4.0 (Cory Fields) 387879d [depends] ZeroMQ 4.2.2 (fanquake) Pull request description: Update depends ZeroMQ to 4.2.2, the release notes are available [here](https://github.com/zeromq/libzmq/releases). We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release). `--without-documentation` is deprecated and has been replaced with `--without-docs`. `--disable-perf` disables building performance measuring tools, which are enabled by default, see the libzmq [configure.ac](https://github.com/zeromq/libzmq/blob/master/configure.ac#L367). Updated dependencies.md. `--disable-curve-keygen` disable building the curve key generation tool. See [here](https://github.com/zeromq/libzmq/blob/master/configure.ac#L405). Can someone on windows test that this is still working correctly. Maybe @achow101 ? Tree-SHA512: c6c4b15f545b6de21648f05027b5500fca0e6b5b72e791ac9a0aa523c57f2feb5aae94e42531275dddd922e11e462a52f08be1118ba1629c3cae765b18e5d720

@jonasschnelli

a6365c5 depends: fix libzmq's needless linking against libstdc++ (Cory Fields) Pull request description: Broken gitian builds were introduced with bitcoin#9254. Big thanks to @jonasschnelli for narrowing down the bisection. This is broken for a number of reasons, including: - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever libstdc++ exists, probably shared", which in itself is buggy. - another stdlib (libc++ for example) may be in use Tree-SHA512: d84968ee680f32ea799034ee516e9477fff2b1ef1b7c9a8ef1941631520ab196ecd50f5d64f3ed1c84113ead44be5e3ddf6ff2ae0277625bdeed05f1da89e017

13a399a depends: patch pthread_set_name_np out of zeromq (Cory Fields) 8f79226 depends: zeromq 4.2.3 (fanquake) Pull request description: This is a followup to bitcoin#9254 and bitcoin#11981. Zeromq 4.2.3 was released just after bitcoin#9254 was merged, and contains a years worth of improvements/bug fixes. See the release notes [here](https://github.com/zeromq/libzmq/releases/tag/v4.2.3). Todo: - [ ] Add zeromq-4.2.3.tar.gz to /depends-sources on bitcoincore.org - [ ] Verify gitian builds are still OK - [ ] Check: zeromq/libzmq#2787 Tree-SHA512: 85e06f47be3e1fdedcee50ce90e3391d69df2ea1c167472ffc3126d8970d418eb75141b970e422eb2fda9a8cad00e6ba5b36afa53565171a9ebaa152a9dc9b60 (cherry picked from commit 765a3eb) # Conflicts: # doc/dependencies.md

Summary: ``` Update depends ZeroMQ to 4.2.2, the release notes are available here. We can drop both patches, as they have both been merged upstream (they actually had been for some time but just hadn't yet made it into a release). --without-documentation is deprecated and has been replaced with --without-docs. --disable-perf disables building performance measuring tools, which are enabled by default, see the libzmq configure.ac. Updated dependencies.md. --disable-curve-keygen disable building the curve key generation tool. See here. ``` Backport of core [[bitcoin/bitcoin#9254 | PR9254]] and [[bitcoin/bitcoin#11981 | PR11981]] (related bugfix). Depends on D5577. Test Plan: Run the Gitian builds. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5574

fanquake added the Build system label Dec 1, 2016

fanquake assigned theuni Dec 1, 2016

fanquake force-pushed the zeromq-4-2-0 branch from fc671e2 to 247139a Compare January 4, 2017 09:19

fanquake changed the title ~~[depends] ZeroMQ 4.2.0~~ [depends] ZeroMQ 4.2.1 Jan 4, 2017

fanquake mentioned this pull request Jan 4, 2017

[Depends] Dependency updates for 0.14.0 #9468

Merged

fanquake force-pushed the zeromq-4-2-0 branch from 258efb3 to 2fa6ff4 Compare January 16, 2017 02:20

fanquake force-pushed the zeromq-4-2-0 branch from 2fa6ff4 to 746e4ca Compare February 19, 2017 13:26

fanquake changed the title ~~[depends] ZeroMQ 4.2.1~~ [depends] ZeroMQ 4.2.2 Feb 19, 2017

fanquake force-pushed the zeromq-4-2-0 branch from 746e4ca to b25926f Compare March 30, 2017 08:25

laanwj added the Upstream label Apr 3, 2017

fanquake force-pushed the zeromq-4-2-0 branch 3 times, most recently from a543122 to b598a4a Compare April 27, 2017 08:58

fanquake mentioned this pull request May 3, 2017

0.15.0 Depends Updates #10325

Merged

fanquake force-pushed the zeromq-4-2-0 branch 3 times, most recently from 0b862a9 to c87403c Compare May 13, 2017 05:20

laanwj added this to the 0.16.0 milestone Aug 23, 2017

fanquake force-pushed the zeromq-4-2-0 branch 5 times, most recently from 6feca2f to 7a49c06 Compare September 10, 2017 07:00

laanwj merged commit 126999d into bitcoin:master Nov 30, 2017

theuni mentioned this pull request Dec 21, 2017

Fix gitian build after libzmq bump #11981

Merged

fanquake mentioned this pull request Dec 22, 2017

[depends] zeromq 4.2.3 #11986

Merged

3 tasks

sickpig mentioned this pull request Jun 5, 2018

[PORT] Depends cherries BitcoinUnlimited/BitcoinUnlimited#1120

Merged

fanquake deleted the zeromq-4-2-0 branch December 16, 2019 20:18

str4d mentioned this pull request Oct 5, 2020

Update ZeroMQ zcash/zcash#4766

Merged

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[depends] ZeroMQ 4.2.2 #9254

[depends] ZeroMQ 4.2.2 #9254

fanquake commented Dec 1, 2016 •

edited

jonasschnelli commented Dec 1, 2016

fanquake commented Dec 2, 2016 •

edited

fanquake commented Jan 4, 2017

laanwj commented Jan 5, 2017 •

edited

laanwj commented Apr 3, 2017

TheBlueMatt commented Sep 29, 2017

fanquake commented Oct 6, 2017 •

edited

fanquake commented Nov 29, 2017

theuni commented Nov 29, 2017

[depends] ZeroMQ 4.2.2 #9254

[depends] ZeroMQ 4.2.2 #9254

Conversation

fanquake commented Dec 1, 2016 • edited

jonasschnelli commented Dec 1, 2016

fanquake commented Dec 2, 2016 • edited

fanquake commented Jan 4, 2017

laanwj commented Jan 5, 2017 • edited

laanwj commented Apr 3, 2017

TheBlueMatt commented Sep 29, 2017

fanquake commented Oct 6, 2017 • edited

fanquake commented Nov 29, 2017

theuni commented Nov 29, 2017

fanquake commented Dec 1, 2016 •

edited

fanquake commented Dec 2, 2016 •

edited

laanwj commented Jan 5, 2017 •

edited

fanquake commented Oct 6, 2017 •

edited