Skip to content

/bitcoin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add basic test for BIP34 #15059

Merged
merged 1 commit into from Jan 8, 2019
+26 −13

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
4 participants
@MarcoFalke @DrahtBot @laanwj @jnewbery
@MarcoFalke
Copy link
Member

commented Dec 29, 2018

BIP34 was disabled for testing, which explains why it had no test.

Fix that by enabling it and adding a test.
@MarcoFalke
test: Add basic test for BIP34
Verified
This commit was signed with a verified signature.
@MarcoFalke MarcoFalke
GPG key ID: CE2B75697E69A548 Learn about signing commits
Loading status checks…
fab17e8

@MarcoFalke MarcoFalke added the Tests label Dec 29, 2018

@DrahtBot

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Dec 29, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Coverage

Coverage Change (pull 15059, 1d880e789c555b6653b3984f87ae052a816831c4) Reference (master, 96d912b)
Lines +0.0000 % 87.3369 %
Functions +0.0151 % 84.4498 %
Branches +0.0105 % 51.3677 %

Updated at: 2018-12-29T19:54:43.800451.
@laanwj

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 2, 2019

utACK fab17e8

@laanwj laanwj merged commit fab17e8 into bitcoin:master Jan 8, 2019
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 8, 2019

@laanwj
Merge #15059: test: Add basic test for BIP34 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
Verified
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 1E4AED62986CD25D Learn about signing commits
Loading status checks…
c6806ee
@jnewbery

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jan 9, 2019

tested ACK fab17e8.

It might be a good idea to update the default block version number to >=2 (or better, >=4) here:

bitcoin/test/functional/test_framework/messages.py

Line 543 in 699d0bd

self.nVersion = 1

Building a chain that exceeds 500 blocks and having it rejected for 'bad-version(0x00000001)' is probably going to trip some people up.

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1812-testBip34 branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.