Skip to content

test: Add basic test for BIP34 #15059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2019
Merged

test: Add basic test for BIP34 #15059

merged 1 commit into from
Jan 8, 2019

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 29, 2018

BIP34 was disabled for testing, which explains why it had no test.

Fix that by enabling it and adding a test.

@maflcko maflcko added the Tests label Dec 29, 2018
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Coverage

Coverage Change (pull 15059, 1d880e789c555b6653b3984f87ae052a816831c4) Reference (master, 96d912b)
Lines +0.0000 % 87.3369 %
Functions +0.0151 % 84.4498 %
Branches +0.0105 % 51.3677 %

Updated at: 2018-12-29T19:54:43.800451.

@laanwj
Copy link
Member

laanwj commented Jan 2, 2019

utACK fab17e8

@laanwj laanwj merged commit fab17e8 into bitcoin:master Jan 8, 2019
laanwj added a commit that referenced this pull request Jan 8, 2019
@laanwj
Merge #15059: test: Add basic test for BIP34
c6806ee 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
@jnewbery
Copy link
Contributor

jnewbery commented Jan 9, 2019

tested ACK fab17e8.

It might be a good idea to update the default block version number to >=2 (or better, >=4) here:

bitcoin/test/functional/test_framework/messages.py

Line 543 in 699d0bd

self.nVersion = 1

Building a chain that exceeds 500 blocks and having it rejected for 'bad-version(0x00000001)' is probably going to trip some people up.

@maflcko maflcko deleted the Mf1812-testBip34 branch January 9, 2019 22:36
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jun 23, 2020
@deadalnix
test: Add basic test for BIP34
e54a99e 
Summary: This is a backport of Core [[bitcoin/bitcoin#15059 | PR15059]]

Test Plan:
  ninja all check-extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6679
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 23, 2021
@laanwj @vijaydasmp
Merge bitcoin#15059: test: Add basic test for BIP34
ca7f9e4 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 23, 2021
@laanwj @vijaydasmp
Merge bitcoin#15059: test: Add basic test for BIP34
c1446bc 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 23, 2021
@laanwj @vijaydasmp
Merge bitcoin#15059: test: Add basic test for BIP34
9b1c175 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 26, 2021
@laanwj @vijaydasmp
Merge bitcoin#15059: test: Add basic test for BIP34
d757255 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 26, 2021
@laanwj @vijaydasmp
Merge bitcoin#15059: test: Add basic test for BIP34
e761f72 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 26, 2021
@laanwj @vijaydasmp
Merge bitcoin#15059: test: Add basic test for BIP34
782a2fe 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 29, 2021
@laanwj @vijaydasmp
Merge bitcoin#15059: test: Add basic test for BIP34
8e1c294 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 30, 2021
@laanwj @vijaydasmp
Merge bitcoin#15059: test: Add basic test for BIP34
f6c6561 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Nov 2, 2021
@laanwj @vijaydasmp
Merge bitcoin#15059: test: Add basic test for BIP34
28b7695 
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maflcko @DrahtBot @laanwj @jnewbery