test: Add basic test for BIP34 #15059
Merged
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Coverage
Updated at: 2018-12-29T19:54:43.800451. |
|
utACK fab17e8 |
laanwj
added a commit
that referenced
this issue
Jan 8, 2019
fab17e8 test: Add basic test for BIP34 (MarcoFalke) Pull request description: BIP34 was disabled for testing, which explains why it had no test. Fix that by enabling it and adding a test. Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
|
tested ACK fab17e8. It might be a good idea to update the default block version number to >=2 (or better, >=4) here: Building a chain that exceeds 500 blocks and having it rejected for 'bad-version(0x00000001)' is probably going to trip some people up. |
deadalnix
added a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this issue
Jun 23, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#15059 | PR15059]] Test Plan: ninja all check-extended Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D6679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
BIP34 was disabled for testing, which explains why it had no test.
Fix that by enabling it and adding a test.
The text was updated successfully, but these errors were encountered: