Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add basic test for BIP34 #15059

merged 1 commit into from Jan 8, 2019


Copy link

@MarcoFalke MarcoFalke commented Dec 29, 2018

BIP34 was disabled for testing, which explains why it had no test.

Fix that by enabling it and adding a test.

Copy link

@DrahtBot DrahtBot commented Dec 29, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.


Coverage Change (pull 15059, 1d880e789c555b6653b3984f87ae052a816831c4) Reference (master, 96d912b)
Lines +0.0000 % 87.3369 %
Functions +0.0151 % 84.4498 %
Branches +0.0105 % 51.3677 %

Updated at: 2018-12-29T19:54:43.800451.

Copy link

@laanwj laanwj commented Jan 2, 2019

utACK fab17e8

@laanwj laanwj merged commit fab17e8 into bitcoin:master Jan 8, 2019
2 checks passed
laanwj added a commit that referenced this issue Jan 8, 2019
fab17e8 test: Add basic test for BIP34 (MarcoFalke)

Pull request description:

  BIP34 was disabled for testing, which explains why it had no test.

  Fix that by enabling it and adding a test.

Tree-SHA512: 9cb5702d474117ce6420226eb93ee09d6fb5fc856fabc8b67abe56a088cd727674e0e5462000e1afa83b911374036f90abdbdde56a8c236a75572ed47e10a00f
Copy link

@jnewbery jnewbery commented Jan 9, 2019

tested ACK fab17e8.

It might be a good idea to update the default block version number to >=2 (or better, >=4) here:

Building a chain that exceeds 500 blocks and having it rejected for 'bad-version(0x00000001)' is probably going to trip some people up.

@MarcoFalke MarcoFalke deleted the Mf1812-testBip34 branch Jan 9, 2019
deadalnix added a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Jun 23, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#15059 | PR15059]]

Test Plan:
  ninja all check-extended

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants