Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_msvc: Fix the build problem in libbitcoin_server #15110

Merged
merged 1 commit into from Jan 7, 2019
Merged

build_msvc: Fix the build problem in libbitcoin_server #15110

merged 1 commit into from Jan 7, 2019

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Jan 5, 2019

Fixes #15049

The reason of this problem is existance two similar lines in the libbitcoin_server.vcxproj file that appears after the executing the msvc-autogen.py script .

line 157

<ClCompile Include="..\..\src\rpc\net.cpp">
  <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">$(IntDir)\netrpc.obj</ObjectFileName>
  <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">$(IntDir)\netrpc.obj</ObjectFileName>
  <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">$(IntDir)\netrpc.obj</ObjectFileName>
  <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|x64'">$(IntDir)\netrpc.obj</ObjectFileName>
</ClCompile>

line 256

<ClCompile Include="..\..\src\rpc\net.cpp"> 
  <ObjectFileName>$(IntDir)rpc_net.obj</ObjectFileName>
</ClCompile>
@MarcoFalke MarcoFalke changed the title Fix the build problem in libbitcoin_server build_msvc: Fix the build problem in libbitcoin_server Jan 5, 2019
@fanquake
Copy link
Member

@fanquake fanquake commented Jan 5, 2019

tACK c98f886

Prior to this change, the libbitcoin_server "solution" is unusable:
screen shot 2019-01-06 at 12 48 56 am

After applying c98f886 and regenerating the project files it works correctly:
vstudio

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jan 5, 2019

@Mr-Leshiy Very nice first-time contribution! Welcome as a contributor! :-)

You might want to check out, test and review #14151 if you have access to MSVC. That would be awesome!

@Mr-Leshiy
Copy link
Contributor Author

@Mr-Leshiy Mr-Leshiy commented Jan 6, 2019

@practicalswift thank you.
Of course, i will check it.

@laanwj laanwj merged commit c98f886 into bitcoin:master Jan 7, 2019
2 checks passed
laanwj added a commit that referenced this issue Jan 7, 2019
c98f886 Fix the build problem in libbitcoin_server (Alexey Poghilenkov)

Pull request description:

  Fixes #15049

  The reason of this problem is existance two similar lines in the libbitcoin_server.vcxproj file that appears after the executing the msvc-autogen.py script .

  line 157
  >   <ItemGroup>
      <ClCompile Include="..\..\src\rpc\net.cpp">
        <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">$(IntDir)\netrpc.obj</ObjectFileName>
        <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">$(IntDir)\netrpc.obj</ObjectFileName>
        <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">$(IntDir)\netrpc.obj</ObjectFileName>
        <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|x64'">$(IntDir)\netrpc.obj</ObjectFileName>
      </ClCompile>

  line 256

  >   <ItemGroup>
      <ClCompile Include="..\..\src\rpc\net.cpp">
        <ObjectFileName>$(IntDir)rpc_net.obj</ObjectFileName>
      </ClCompile>

Tree-SHA512: 0f2841a32253c503731c9007fa2a02d330ab4b670c154dcfce6fd0919752317bc3133f074d21e90f73054ab3c0a8a3d222b4fadc34fbcecd3e8af093eea38b49
linuxsh2 added a commit to linuxsh2/dash that referenced this issue Sep 16, 2021
…server

c98f886 Fix the build problem in libbitcoin_server (Alexey Poghilenkov)

Pull request description:

  Fixes bitcoin#15049

  The reason of this problem is existance two similar lines in the libbitcoin_server.vcxproj file that appears after the executing the msvc-autogen.py script .

  line 157
  >   <ItemGroup>
      <ClCompile Include="..\..\src\rpc\net.cpp">
        <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">$(IntDir)\netrpc.obj</ObjectFileName>
        <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">$(IntDir)\netrpc.obj</ObjectFileName>
        <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">$(IntDir)\netrpc.obj</ObjectFileName>
        <ObjectFileName Condition="'$(Configuration)|$(Platform)'=='Release|x64'">$(IntDir)\netrpc.obj</ObjectFileName>
      </ClCompile>

  line 256

  >   <ItemGroup>
      <ClCompile Include="..\..\src\rpc\net.cpp">
        <ObjectFileName>$(IntDir)rpc_net.obj</ObjectFileName>
      </ClCompile>

Tree-SHA512: 0f2841a32253c503731c9007fa2a02d330ab4b670c154dcfce6fd0919752317bc3133f074d21e90f73054ab3c0a8a3d222b4fadc34fbcecd3e8af093eea38b49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants