[WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories folder #15133
Conversation
|
You may want to make this a "test_util" library instead of a "factory" library. That would clarify what this code is used for, make this a test-only change that should be easier to merge, and also create a home for other test code that could be reused. |
src/factories/transactions.cpp
Outdated
|
|
||
| CMutableTransaction BuildSpendingTransaction(const CScript& scriptSig, const CMutableTransaction& txCredit) | ||
| { | ||
| return BuildSpendingTransaction(scriptSig, txCredit.vout[0].nValue, txCredit.GetHash()); |
There was a problem hiding this comment.
Aware of the implicit precision losing conversion from long (CAmount) to int here? Should be made explicit or perhaps add an assertion for the allowed value range?
Empact
force-pushed
the
factories
branch
2 times, most recently
from
05ae0da to
73fbea2
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
…folder This is a first step toward a library of common factory functions for test and bench purposes.
This is a first step toward a library of common factory functions for test and
bench purposes.
This reduces duplication and supports writing tests by giving easier construction
of the underlying types.
Previously open as #14892.