Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: Remove unused FUNCTIONAL_TESTS_CONFIG #15303

Merged
merged 2 commits into from Feb 1, 2019
Merged

travis: Remove unused FUNCTIONAL_TESTS_CONFIG #15303

merged 2 commits into from Feb 1, 2019

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jan 31, 2019

Closes #14163

@Empact
Copy link
Member

Empact commented Jan 31, 2019

Job timed out, restarted

@maflcko maflcko force-pushed the Mf1901-travisFun branch 4 times, most recently from fa2e210 to fa6bb1c Compare January 31, 2019 21:16
@maflcko
Copy link
Member Author

maflcko commented Jan 31, 2019

@scravy Any idea why this fails?

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15295 (fuzz: Add test/fuzz/test_runner.py and run it in travis by MarcoFalke)
  • #12134 (Build previous releases and run functional tests by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake fanquake added the Tests label Jan 31, 2019
@maflcko maflcko force-pushed the Mf1901-travisFun branch 9 times, most recently from fa86976 to fab3ede Compare February 1, 2019 19:10
@practicalswift
Copy link
Contributor

Concept ACK

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Feb 1, 2019
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
b3a7153 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
@maflcko maflcko merged commit facaae4 into bitcoin:master Feb 1, 2019
@Empact
Copy link
Member

Empact commented Feb 1, 2019

post-utACK facaae4

@maflcko maflcko deleted the Mf1901-travisFun branch February 1, 2019 23:02
@fanquake
Copy link
Member

fanquake commented Feb 2, 2019

Just noting, looks like this change is going to force every PR prior to this one to be rebased on master, otherwise Travis is failing with:

$ if [ $SECONDS -gt 1200 ]; then set +o errexit; echo "Travis early exit to cache current state"; false; else set -o errexit; source .travis/test_06_script.sh; fi
/home/travis/.travis/job_stages: line 104: .travis/test_06_script.sh: No such file or directory

Discussion here (line 83).

@maflcko
Copy link
Member Author

maflcko commented Feb 2, 2019

Not all pull requests need rebase (only those that failed prior to now and need to be run again). A force push or push should also suffice, though.

@Empact
Copy link
Member

Empact commented Feb 2, 2019

Yeah relatedly, travis runs against the tested branch merged with master. Eg here’s the tested commit and associated job:
fde2cad
https://travis-ci.org/bitcoin/bitcoin/builds/487988491

Not sure what happens on merge conflict.

vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 24, 2021
@vijaydasmp
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
c495d30 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 24, 2021
@vijaydasmp
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
be0e805 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 25, 2021
@vijaydasmp
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
acc5f98 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 25, 2021
@vijaydasmp
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
08872db 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 27, 2021
@vijaydasmp
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
9a21263 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 28, 2021
@vijaydasmp
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
2363b64 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 28, 2021
@vijaydasmp
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
c484d21 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
@vijaydasmp vijaydasmp mentioned this pull request Sep 29, 2021
Merged
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Sep 30, 2021
@vijaydasmp
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
6c3e37d 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this pull request Oct 1, 2021
@vijaydasmp
Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
439bbdf 
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wallet: heap-use-after-free on multiwallet shutdown
5 participants
@maflcko @Empact @DrahtBot @practicalswift @fanquake