Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Remove unused FUNCTIONAL_TESTS_CONFIG #15303

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
5 participants
@MarcoFalke
Copy link
Member

commented Jan 31, 2019

Closes #14163

@Empact

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

Job timed out, restarted

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1901-travisFun branch 4 times, most recently from fa2e210 to fa6bb1c Jan 31, 2019

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Jan 31, 2019

@scravy Any idea why this fails?

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15295 (fuzz: Add test/fuzz/test_runner.py and run it in travis by MarcoFalke)
  • #12134 (Build previous releases and run functional tests by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake fanquake added the Tests label Jan 31, 2019

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1901-travisFun branch 9 times, most recently from fa86976 to fab3ede Jan 31, 2019

@practicalswift

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

Concept ACK

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1901-travisFun branch from fab3ede to facaae4 Feb 1, 2019

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Feb 1, 2019

Merge bitcoin#15303: travis: Remove unused FUNCTIONAL_TESTS_CONFIG
facaae4 travis: Save cache when compilation took very long (MarcoFalke)
faee6c9 travis: Remove unused FUNCTIONAL_TESTS_CONFIG (MarcoFalke)

Pull request description:

  Closes bitcoin#14163

Tree-SHA512: fb3dd0b7a0a3ee7ac1c6d4e9314239cd03ab4a11f04b6345ef4a1f50ea2b79ea4248c41e99a6fb923a4b1b477758c4fa665d56a4ab703acf5a58dbc7d852ffc4

@MarcoFalke MarcoFalke merged commit facaae4 into bitcoin:master Feb 1, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Empact

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

post-utACK facaae4

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1901-travisFun branch Feb 1, 2019

@fanquake

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

Just noting, looks like this change is going to force every PR prior to this one to be rebased on master, otherwise Travis is failing with:

$ if [ $SECONDS -gt 1200 ]; then set +o errexit; echo "Travis early exit to cache current state"; false; else set -o errexit; source .travis/test_06_script.sh; fi
/home/travis/.travis/job_stages: line 104: .travis/test_06_script.sh: No such file or directory

Discussion here (line 83).

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Feb 2, 2019

Not all pull requests need rebase (only those that failed prior to now and need to be run again). A force push or push should also suffice, though.

@Empact

This comment has been minimized.

Copy link
Member

commented Feb 2, 2019

Yeah relatedly, travis runs against the tested branch merged with master. Eg here’s the tested commit and associated job:
fde2cad
https://travis-ci.org/bitcoin/bitcoin/builds/487988491

Not sure what happens on merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.