Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpc] deriveaddresses: add range to CRPCConvertParam #15510

Merged
merged 1 commit into from Mar 2, 2019

Conversation

@Sjors
Copy link
Member

@Sjors Sjors commented Mar 1, 2019

Missing from #15497

@fanquake fanquake added this to the 0.18.0 milestone Mar 1, 2019
@Sjors Sjors force-pushed the 2019/02/rpcconsistentrange branch from 349c8cf to 9586157 Mar 1, 2019
@Sjors
Copy link
Member Author

@Sjors Sjors commented Mar 1, 2019

The linter caught a related mistake in CRPCCommand, so I fixed that as well.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Mar 1, 2019

ACK 9586157

Before:

$ ./src/bitcoin-cli -named deriveaddresses descriptor="wpkh(tprv8ZgxMBicQKsPd7Uf69XL1XwhmjHopUGep8GuEiJDZmbQz6o58LninorQAfcKZWARbtRtfnLcJ5MQ2AtHcQJCCRUcMRvmDUjyEmNUWwx8UbK/1/1/*)#kft60nuy" range=3
error code: -8
error message:
Unknown named parameter range

After:

$ ./src/bitcoin-cli -named deriveaddresses descriptor="wpkh(tprv8ZgxMBicQKsPd7Uf69XL1XwhmjHopUGep8GuEiJDZmbQz6o58LninorQAfcKZWARbtRtfnLcJ5MQ2AtHcQJCCRUcMRvmDUjyEmNUWwx8UbK/1/1/*)#kft60nuy" range=0
[
  "bcrt1qjqmxmkpmxt80xz4y3746zgt0q3u3ferr34acd5"
]

@fanquake
Copy link
Member

@fanquake fanquake commented Mar 1, 2019

utACK 9586157

@Sjors
Copy link
Member Author

@Sjors Sjors commented Mar 1, 2019

$ bitcoin-cli -named deriveaddresses descriptor="wpkh(tprv8...bK/1/1/*)#kft60nuy" range=3

TIL how to use named params...

@promag
Copy link
Member

@promag promag commented Mar 1, 2019

utACK 9586157.

@laanwj
Copy link
Member

@laanwj laanwj commented Mar 2, 2019

utACK 9586157

@laanwj laanwj merged commit 9586157 into bitcoin:master Mar 2, 2019
2 checks passed
laanwj added a commit that referenced this issue Mar 2, 2019
9586157 [rpc] deriveaddresses: add range to CRPCConvertParam (Sjors Provoost)

Pull request description:

  Missing from #15497

Tree-SHA512: 469de3f896bcd3435a480685e5257c51ba895df0311329d5e5a3cb2e1894e5358324473d998ea45221776aefe8836a7af6c4f12198a36d2d10bf6761991cfd60
@Sjors Sjors deleted the 2019/02/rpcconsistentrange branch Mar 2, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Oct 2, 2020
Summary:
Related to D6614

Backport of Core [[bitcoin/bitcoin#15510 | PR15510]]

Test Plan:
```
ninja && ninja check
sudo ninja install
```

Before:
```
$ bitcoin-cli -named deriveaddresses descriptor="pkh([d34db33f/84h/0h/0h]xpub6DJ2dNUysrn5Vt36jH2KLBT2i1auw1tTSSomg8PhqNiUtx8QX2SvC9nrHu81fT41fvDUnhMjEzQgXnQjKEu3oaqMSzhSrHMxyyoEAmUHQbY/0/*)#3vhfv5h5" range=3
error code: -8
error message:
Unknown named parameter range
```

After:
```
$ bitcoin-cli -named deriveaddresses descriptor="pkh([d34db33f/84h/0h/0h]xpub6DJ2dNUysrn5Vt36jH2KLBT2i1auw1tTSSomg8PhqNiUtx8QX2SvC9nrHu81fT41fvDUnhMjEzQgXnQjKEu3oaqMSzhSrHMxyyoEAmUHQbY/0/*)#3vhfv5h5" range=3
[
  "bitcoincash:qprtnzgt6eph9hh0ejsn508qjjhspcagsses6cmsf0",
  "bitcoincash:qpqmyerc9q5atsvqlx668ulur2s2le36qv996lljtt",
  "bitcoincash:qz338f4ef5kl8ygqcwg822m99nyydq4lju7mlv08ny",
  "bitcoincash:qqe9495xzm8g80z9cm3angqq9pcn3978c5xuj82h68"
]
```

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7730
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 15, 2021
…aram

9586157 [rpc] deriveaddresses: add range to CRPCConvertParam (Sjors Provoost)

Pull request description:

  Missing from bitcoin#15497

Tree-SHA512: 469de3f896bcd3435a480685e5257c51ba895df0311329d5e5a3cb2e1894e5358324473d998ea45221776aefe8836a7af6c4f12198a36d2d10bf6761991cfd60
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 16, 2021
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 16, 2021
…aram

9586157 [rpc] deriveaddresses: add range to CRPCConvertParam (Sjors Provoost)

Pull request description:

  Missing from bitcoin#15497

Tree-SHA512: 469de3f896bcd3435a480685e5257c51ba895df0311329d5e5a3cb2e1894e5358324473d998ea45221776aefe8836a7af6c4f12198a36d2d10bf6761991cfd60
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 16, 2021
…aram

9586157 [rpc] deriveaddresses: add range to CRPCConvertParam (Sjors Provoost)

Pull request description:

  Missing from bitcoin#15497

Tree-SHA512: 469de3f896bcd3435a480685e5257c51ba895df0311329d5e5a3cb2e1894e5358324473d998ea45221776aefe8836a7af6c4f12198a36d2d10bf6761991cfd60
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Sep 20, 2021
…aram

9586157 [rpc] deriveaddresses: add range to CRPCConvertParam (Sjors Provoost)

Pull request description:

  Missing from bitcoin#15497

Tree-SHA512: 469de3f896bcd3435a480685e5257c51ba895df0311329d5e5a3cb2e1894e5358324473d998ea45221776aefe8836a7af6c4f12198a36d2d10bf6761991cfd60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants