Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpc] deriveaddresses: add range to CRPCConvertParam #15510

Merged
merged 1 commit into from Mar 2, 2019

Conversation

Projects
None yet
5 participants
@Sjors
Copy link
Member

commented Mar 1, 2019

Missing from #15497

@fanquake fanquake added this to the 0.18.0 milestone Mar 1, 2019

@Sjors Sjors force-pushed the Sjors:2019/02/rpcconsistentrange branch from 349c8cf to 9586157 Mar 1, 2019

@Sjors

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

The linter caught a related mistake in CRPCCommand, so I fixed that as well.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

ACK 9586157

Before:

$ ./src/bitcoin-cli -named deriveaddresses descriptor="wpkh(tprv8ZgxMBicQKsPd7Uf69XL1XwhmjHopUGep8GuEiJDZmbQz6o58LninorQAfcKZWARbtRtfnLcJ5MQ2AtHcQJCCRUcMRvmDUjyEmNUWwx8UbK/1/1/*)#kft60nuy" range=3
error code: -8
error message:
Unknown named parameter range

After:

$ ./src/bitcoin-cli -named deriveaddresses descriptor="wpkh(tprv8ZgxMBicQKsPd7Uf69XL1XwhmjHopUGep8GuEiJDZmbQz6o58LninorQAfcKZWARbtRtfnLcJ5MQ2AtHcQJCCRUcMRvmDUjyEmNUWwx8UbK/1/1/*)#kft60nuy" range=0
[
  "bcrt1qjqmxmkpmxt80xz4y3746zgt0q3u3ferr34acd5"
]
@fanquake

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

utACK 9586157

@Sjors

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

$ bitcoin-cli -named deriveaddresses descriptor="wpkh(tprv8...bK/1/1/*)#kft60nuy" range=3

TIL how to use named params...

@promag

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

utACK 9586157.

@laanwj

This comment has been minimized.

Copy link
Member

commented Mar 2, 2019

utACK 9586157

@laanwj laanwj merged commit 9586157 into bitcoin:master Mar 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 2, 2019

Merge #15510: [rpc] deriveaddresses: add range to CRPCConvertParam
9586157 [rpc] deriveaddresses: add range to CRPCConvertParam (Sjors Provoost)

Pull request description:

  Missing from #15497

Tree-SHA512: 469de3f896bcd3435a480685e5257c51ba895df0311329d5e5a3cb2e1894e5358324473d998ea45221776aefe8836a7af6c4f12198a36d2d10bf6761991cfd60

@Sjors Sjors deleted the Sjors:2019/02/rpcconsistentrange branch Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.