-
Notifications
You must be signed in to change notification settings - Fork 37.9k
docs: Clarify PR guidelines w/re documentation #15794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
ACK f4a230b |
utACK f4a230b |
laanwj
added a commit
that referenced
this pull request
May 9, 2019
f4a230b docs: Clarify PR guidelines w/re documentation (Carl Dong) Pull request description: PRs should change documentation accordingly when the behaviour of code changes. ACKs for commit f4a230: practicalswift: ACK f4a230b fanquake: utACK f4a230b Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 10, 2019
f4a230b docs: Clarify PR guidelines w/re documentation (Carl Dong) Pull request description: PRs should change documentation accordingly when the behaviour of code changes. ACKs for commit f4a230: practicalswift: ACK f4a230b fanquake: utACK f4a230b Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
Merge #15794:docs:Clarify PR for review |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 27, 2021
f4a230b docs: Clarify PR guidelines w/re documentation (Carl Dong) Pull request description: PRs should change documentation accordingly when the behaviour of code changes. ACKs for commit f4a230: practicalswift: ACK f4a230b fanquake: utACK f4a230b Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 28, 2021
f4a230b docs: Clarify PR guidelines w/re documentation (Carl Dong) Pull request description: PRs should change documentation accordingly when the behaviour of code changes. ACKs for commit f4a230: practicalswift: ACK f4a230b fanquake: utACK f4a230b Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 29, 2021
f4a230b docs: Clarify PR guidelines w/re documentation (Carl Dong) Pull request description: PRs should change documentation accordingly when the behaviour of code changes. ACKs for commit f4a230: practicalswift: ACK f4a230b fanquake: utACK f4a230b Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
f4a230b docs: Clarify PR guidelines w/re documentation (Carl Dong) Pull request description: PRs should change documentation accordingly when the behaviour of code changes. ACKs for commit f4a230: practicalswift: ACK f4a230b fanquake: utACK f4a230b Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
f4a230b docs: Clarify PR guidelines w/re documentation (Carl Dong) Pull request description: PRs should change documentation accordingly when the behaviour of code changes. ACKs for commit f4a230: practicalswift: ACK f4a230b fanquake: utACK f4a230b Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 8, 2021
f4a230b docs: Clarify PR guidelines w/re documentation (Carl Dong) Pull request description: PRs should change documentation accordingly when the behaviour of code changes. ACKs for commit f4a230: practicalswift: ACK f4a230b fanquake: utACK f4a230b Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 10, 2021
f4a230b docs: Clarify PR guidelines w/re documentation (Carl Dong) Pull request description: PRs should change documentation accordingly when the behaviour of code changes. ACKs for commit f4a230: practicalswift: ACK f4a230b fanquake: utACK f4a230b Tree-SHA512: 6d9d65d7f0f9bc8f324ee16f03169df28fb512c58bb71093128cf16797b25533cdc992bc8757034a99d6fa6423a3129ca7cf2ab2da857535f409a683486fd4ab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs should change documentation accordingly when the behaviour of code changes.