Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: mention creating application support bitcoin folder on OSX #15802

Merged
merged 1 commit into from Apr 15, 2019

Conversation

Projects
None yet
5 participants
@JimmyMow
Copy link

commented Apr 12, 2019

When setting up bitcoin core on my new MacBook via the macOS Build Instructions and Notes, running touch "/Users/${USER}/Library/Application Support/Bitcoin/bitcoin.conf" resulted in No such file or directory because my /Users/${USER}/Library/Application Support/Bitcoin/ folder had not been created yet.

This PR adds mkdir "/Users/${USER}/Library/Application Support/Bitcoin" to the documentation before creating the configuration file with touch "/Users/${USER}/Library/Application Support/Bitcoin/bitcoin.conf"

@fanquake fanquake added the Docs label Apr 12, 2019

@merland

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

utACK

One suggestion would be to use mkdir -p instead of the plain mkdir.
Will make the command work without error if the dir already exists, or if you - for some reason - issue it more than once.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

ACK 7ce67bb modulo mkdir -p nit :-)

@laanwj laanwj changed the title doc: create application support bitcoin folder doc: mention creating application support bitcoin folder on OSX Apr 12, 2019

@JimmyMow JimmyMow force-pushed the JimmyMow:fix/macos-docs branch from 7ce67bb to 8dfbb5c Apr 12, 2019

@JimmyMow

This comment has been minimized.

Copy link
Author

commented Apr 12, 2019

Good call @merland @practicalswift.

Updated to use mkdir -p

@fanquake

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

utACK 8dfbb5c

@laanwj laanwj added this to the 0.18.0 milestone Apr 15, 2019

@laanwj laanwj merged commit 8dfbb5c into bitcoin:master Apr 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 15, 2019

Merge #15802: doc: mention creating application support bitcoin folde…
…r on OSX

8dfbb5c doc: mention creating application support bitcoin folder on OSX (Jack Mallers)

Pull request description:

  When setting up bitcoin core on my new MacBook via the [`macOS Build Instructions and Notes`](https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md), running `touch "/Users/${USER}/Library/Application Support/Bitcoin/bitcoin.conf"` resulted in `No such file or directory` because my `/Users/${USER}/Library/Application Support/Bitcoin/` folder had not been created yet.

  This PR adds `mkdir "/Users/${USER}/Library/Application Support/Bitcoin"` to the documentation before creating the configuration file with `touch "/Users/${USER}/Library/Application Support/Bitcoin/bitcoin.conf"`

ACKs for commit 8dfbb5:
  fanquake:
    utACK 8dfbb5c

Tree-SHA512: c401dae0a681bed77b31939bd29f79837f66c8537da393871fc3596e8c10629b8817ece9c8d49b1b9de34e74e0fbff742a9116b02ce7a71af93f872b87539337

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 15, 2019

@fanquake fanquake referenced this pull request Apr 15, 2019

Merged

[0.18] doc backports #15818

@fanquake

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Backported in #15818.

fanquake added a commit to fanquake/bitcoin that referenced this pull request Apr 16, 2019

laanwj added a commit that referenced this pull request Apr 18, 2019

Merge #15818: [0.18] doc backports
a644780 doc: Clarify RPC versioning (MarcoFalke)
194226f doc: describe onlynet option in doc/tor.md (Jon Atack)
6d2448c doc/dependencies: Fix typo libsrvg->librsvg (Luke Dashjr)
9c572e3 doc: mention creating application support bitcoin folder on OSX (Jack Mallers)
c69138a gitignore: add *.plist (clang-check) (James O'Beirne)
8f7cfb0 gitignore: add *.dat (James O'Beirne)

Pull request description:

  Backports #15684, #15792, #15802,  #15809 to the `0.18` branch.

ACKs for commit a64478:

Tree-SHA512: 6ed524a7b94242f8a738710d4321b98b9e80d6625d384fd83280b38fcb6bb8c468bcec1d980789ad2f4c91a5629ffe5c5314a7353181f08884c5a081840431cc

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Apr 19, 2019

uhliksk added a commit to fxtc-development/fxtc that referenced this pull request May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.