gui: Create wallet menu option follow-ups #16822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
force-pushed
the
createwallet-followup
branch
from
a24befd to
66af07e
Compare
jonatack
changed the title
jonatack
force-pushed
the
createwallet-followup
branch
from
66af07e to
d4072b3
Compare
|
Lone CI failure is a time-out. |
|
Concept ACK, restarted travis job. |
promag
reviewed
Sep 8, 2019
jonatack
force-pushed
the
createwallet-followup
branch
from
d4072b3 to
52d3743
Compare
|
ACK 52d3743. Labels and tooltips correctly update. |
|
Code review ACK 52d3743. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
jonatack
commented
Sep 9, 2019
as well as disablePrivateKeys() to be consistent in naming.
…edialog UI improvements: - update remaining GUI wallet labels and tooltips from passwords to passphrases - improve grammar of labels in askpassphrase dialog and WalletController::closeWallet
jonatack
force-pushed
the
createwallet-followup
branch
from
52d3743 to
1310bff
Compare
jonatack
force-pushed
the
createwallet-followup
branch
from
1310bff to
cad3ab5
Compare
jonatack
added a commit
to jonatack/bitcoin-development
that referenced
this pull request
Sep 9, 2019
This and more was done in: bitcoin/bitcoin#16822
|
I am generally in favor of migrating from "password" to "passphrase". I made this comment in -wizards that nobody should talk about 'the password' in bip39 because 'word' already means a single word from the dictionary which is definitely low entropy. And then I was directed here. |
|
Yes, removing the last user-facing references to "password" has been on my to-do list since June. Since PRs to change UI can invite bikeshedding (there's been a bit of that lately), I waited until related code or a PR (in this case, the PR this one follows up on) touched it to push the changes in 539d940. |
|
Approach ACK cad3ab5 |
|
code review and tACK cad3ab5 |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Sep 16, 2019
cad3ab5 gui: fix autofocus in CreateWalletActivity::askPassphrase() (Jon Atack) 539d940 gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog (Jon Atack) 43aa9b0 gui: rename encrypt(), blank(), and askPasshprase() (Jon Atack) Pull request description: Closes bitcoin#16820. The wallet [name escaping issue](bitcoin#15450 (review)) in that issue predates bitcoin#15450 and is fixed by bitcoin#16826. - [x] rename encrypt() to encryptWallet(), and blank() to makeBlankWallet() // EDIT: updated to isEncryptWalletChecked() isDisablePrivateKeysChecked() isMakeBlankWalletChecked() - [x] fix naming of askPasshprase() to askPassphrase() - [x] fix passphrase labels and tooltip in createwalletdialog.ui and askpassphrasedialog.ui - [x] fix grammar of labels in askpassphrase dialog and WalletController::closeWallet - [x] fix autofocus in CreateWalletActivity::askPassphrase() Squashed down to three commits. Reviewers, to test manually: build, launch the gui wallet, and look at labels/tooltips/focus with the create wallet, encrypt wallet, change password, and close wallet commands. ACKs for top commit: jb55: Approach ACK cad3ab5 instagibbs: code review and tACK cad3ab5 fanquake: ACK cad3ab5 Tree-SHA512: b441fbf8f8cd370dd692bac24f0d3c1b32fc7d947b6c3a2c9ba7cf0bc175a72b3460440f2f10f7632c0e8e0f8e65fe15615a30c46e2c7763bf258c504b457dd6
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 16, 2019
cad3ab5 gui: fix autofocus in CreateWalletActivity::askPassphrase() (Jon Atack) 539d940 gui: fix passphrase labels/tooltip in createwalletdialog/askpassphrasedialog (Jon Atack) 43aa9b0 gui: rename encrypt(), blank(), and askPasshprase() (Jon Atack) Pull request description: Closes bitcoin#16820. The wallet [name escaping issue](bitcoin#15450 (review)) in that issue predates bitcoin#15450 and is fixed by bitcoin#16826. - [x] rename encrypt() to encryptWallet(), and blank() to makeBlankWallet() // EDIT: updated to isEncryptWalletChecked() isDisablePrivateKeysChecked() isMakeBlankWalletChecked() - [x] fix naming of askPasshprase() to askPassphrase() - [x] fix passphrase labels and tooltip in createwalletdialog.ui and askpassphrasedialog.ui - [x] fix grammar of labels in askpassphrase dialog and WalletController::closeWallet - [x] fix autofocus in CreateWalletActivity::askPassphrase() Squashed down to three commits. Reviewers, to test manually: build, launch the gui wallet, and look at labels/tooltips/focus with the create wallet, encrypt wallet, change password, and close wallet commands. ACKs for top commit: jb55: Approach ACK cad3ab5 instagibbs: code review and tACK cad3ab5 fanquake: ACK cad3ab5 Tree-SHA512: b441fbf8f8cd370dd692bac24f0d3c1b32fc7d947b6c3a2c9ba7cf0bc175a72b3460440f2f10f7632c0e8e0f8e65fe15615a30c46e2c7763bf258c504b457dd6
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 20, 2020
…ys() Summary: to be consistent in naming. Backport of Core [[bitcoin/bitcoin#16822 | PR16822]] - part 1 of 3 Commit bitcoin/bitcoin@43aa9b0 Note: on our side the spelling of the method name `askPassphrase` was already good when it was first backported (see D7105) Test Plan: Method renaming without change in the logic. Just compile to make sure it didn't break anything. `ninja` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D8006
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 20, 2020
…etdialog/askpassphrasedialog Summary: UI improvements: - update remaining GUI wallet labels and tooltips from passwords to passphrases - improve grammar of labels in askpassphrase dialog and WalletController::closeWallet Backport of Core [[bitcoin/bitcoin#16822 | PR16822]] - part 2 of 3 Commit bitcoin/bitcoin@539d940 Depends on D8006 Test Plan: `ninja` Run `src/qt/bitcoin-qt`, create a new wallet with encryption and check the text in the dialogs. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D8007
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 21, 2020
…assphrase() Summary: Backport of Core [[bitcoin/bitcoin#16822 | PR16822]] - part 3 of 3 Commit bitcoin/bitcoin@cad3ab5 Depends on D8007 Test Plan: Run `src/qt/bitcoin-qt`, create a new wallet with encryption and check that the dialog is modal. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D8008
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16820. The wallet name escaping issue in that issue predates #15450 and is fixed by #16826.
isEncryptWalletChecked()
isDisablePrivateKeysChecked()
isMakeBlankWalletChecked()
Squashed down to three commits.
Reviewers, to test manually: build, launch the gui wallet, and look at labels/tooltips/focus with the create wallet, encrypt wallet, change password, and close wallet commands.