docs: Update macdeploy README to include all files produced by make deploy
#17142
Conversation
fanquake
changed the title
make deploymake deploy
contrib/macdeploy/README.md
Outdated
| @@ -11,5 +11,5 @@ This script should not be run manually, instead, after building as usual: | |||
| During the process, the disk image window will pop up briefly where the fancy | |||
| settings are applied. This is normal, please do not interfere. | |||
|
|
|||
| When finished, it will produce `Bitcoin-Core.dmg`. | |||
| When finished, it will produce `Bitcoin-Qt.dmg`, `Bitcoin Core.app` and `dist/Bitcoin Core.app`. | |||
There was a problem hiding this comment.
I think it'd make sense to make this a list, and describe what each item is (and what the differences are)
There was a problem hiding this comment.
The two .app files were intentional as both are created, one in the root folder and the other is in the dist.
I am unsure of the differences between these two .app files, so any insight into this would be appreciated
There was a problem hiding this comment.
OK—I think there's a misunderstanding about the purpose of this documentation. The idea here is not to list every intermediate that will be included in the image, but only the end product of the macdeploy (the .dmg image). If the purpose of the intermediate files is not clear, better to not list them.
There was a problem hiding this comment.
Okay thanks @laanwj, I will reverse the change back to just listing the .dmg file as suggested and keep the filename change to match what is actually produced from make deploy (Bitcoin-Qt.dmg)
There was a problem hiding this comment.
Done and squashed the commits 👍
…ed from `make deploy`
|
ACK 4441e58 |
|
ACK 4441e58 - checked that |
…uced by `make deploy` 4441e58 Update macdeploy README to include correctly named `.dmg` file produced from `make deploy` (Zakk) Pull request description: Fixes issue #16909 to update the `contrib/macdeploy/README.md` to match the files produced from `make deploy` The files produced from `make deploy` are as follows: - `Bitcoin-QT.dmg` - `Bitcoin Core.app` - `dist/Bitcoin Core.app` ACKs for top commit: jonasschnelli: ACK 4441e58 fanquake: ACK 4441e58 - checked that `Bitcoin-Qt.dmg` is produced. Tree-SHA512: 99bfadab59c7c516005b051e4a369f330178313a284bb665c22c40f70a6159f175909c08db1b32976ad7b130b53b414f8ba96f8ff7cbd164f2724c0cc151704a
Fixes issue #16909 to update the
contrib/macdeploy/README.mdto match the files produced frommake deployThe files produced from
make deployare as follows:Bitcoin-Qt.dmgBitcoin Core.appdist/Bitcoin Core.app