rpc: Remove unused COINBASE_FLAGS #17519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-jr
reviewed
Nov 19, 2019
MarcoFalke
changed the title
|
I can update RPCHelpMan. Is the right way to do that just remove Does it make sense to remove the |
To remove it, so that the help matches the output.
It's part of the BIP according to @luke-jr so I think it'd be better to keep it but leave it empty, as @MarcoFalke says. |
|
utACK 9aedabe once |
Commit d449772 stopped setting COINBASE_FLAGS, and it looks like it hasn't been used since P2SH. Update the help string to remove "flags", which is not specified in BIP 22.
|
Updated to remove |
|
ACK e9a27cf Show signature and timestampSignature: Timestamp of file with hash |
laanwj
added a commit
that referenced
this issue
Nov 22, 2019
e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula) Pull request description: Commit d449772 stopped setting COINBASE_FLAGS, and it looks like it hasn't been used since P2SH. Following up on #17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig. ACKs for top commit: laanwj: ACK e9a27cf MarcoFalke: ACK e9a27cf💻 Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this issue
Nov 22, 2019
e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula) Pull request description: Commit d449772 stopped setting COINBASE_FLAGS, and it looks like it hasn't been used since P2SH. Following up on bitcoin#17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig. ACKs for top commit: laanwj: ACK e9a27cf MarcoFalke: ACK e9a27cf💻 Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this issue
Nov 29, 2019
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this issue
Nov 5, 2020
Summary: > Commit d449772 stopped setting > COINBASE_FLAGS, and it looks like it hasn't been used since P2SH. > Update the help string to remove "flags", which is not specified in > BIP 22. One occurence of `flags` in the help message was already removed in D8124 This is a backport of Core [[bitcoin/bitcoin#17519 | PR17519]] Test Plan: Verify that nothing is broken as a result of removing `pushKV("flags"...` `ninja all check-all` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8275
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this issue
Nov 10, 2020
e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula) Pull request description: Commit d449772 stopped setting COINBASE_FLAGS, and it looks like it hasn't been used since P2SH. Following up on bitcoin#17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig. ACKs for top commit: laanwj: ACK e9a27cf MarcoFalke: ACK e9a27cf💻 Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this issue
Aug 29, 2021
…oin#18612: script: Remove undocumented and unused operator+
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this issue
Aug 29, 2021
…oin#18612: script: Remove undocumented and unused operator+
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this issue
Aug 29, 2021
…oin#18612: script: Remove undocumented and unused operator+
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this issue
Aug 29, 2021
…oin#18612: script: Remove undocumented and unused operator+ ccccd51 script: Remove undocumented and unused operator+ (MarcoFalke) Pull request description: This operator has no documented use case and is also unused outside of test code. The test code and all other (imaginary) code that might use this operator is written more clear and concise by the existing CScript push operators for opcodes and data. Removing the operator is also going to protect against accidentally reintroducing bugs like this bitcoin@6ff5f71#diff-8458adcedc17d046942185cb709ff5c3L1135 (last time it was used). ACKs for top commit: laanwj: ACK ccccd51 Tree-SHA512: 43898ac77e4d9643d9f8ac6f8f65497a4f0bbb1fb5dcaecc839c3719aa36181ba77befb213e59a9f33a20a29e0173a0e9c4763b1930940b32c3d1598b3e39af9
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this issue
Aug 30, 2021
…to seperate commit
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this issue
Aug 30, 2021
e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula) Pull request description: Commit d449772 stopped setting COINBASE_FLAGS, and it looks like it hasn't been used since P2SH. Following up on bitcoin#17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig. ACKs for top commit: laanwj: ACK e9a27cf MarcoFalke: ACK e9a27cf💻 Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this issue
Aug 31, 2021
* Merge bitcoin#17519: rpc: Remove unused COINBASE_FLAGS e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula) Pull request description: Commit d449772 stopped setting COINBASE_FLAGS, and it looks like it hasn't been used since P2SH. Following up on bitcoin#17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig. ACKs for top commit: laanwj: ACK e9a27cf MarcoFalke: ACK e9a27cf💻 Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334 * Update src/rpc/mining.cpp Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: Wladimir J. van der Laan <laanwj@protonmail.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Commit d449772 stopped setting
COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.
Following up on #17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig.