Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Remove unused COINBASE_FLAGS #17519

Merged
merged 1 commit into from Nov 22, 2019
Merged

Conversation

narula
Copy link
Member

@narula narula commented Nov 19, 2019

Commit d449772 stopped setting
COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.

Following up on #17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig.

Copy link
Member

@MarcoFalke MarcoFalke left a comment

ACK

src/rpc/mining.cpp Show resolved Hide resolved
src/rpc/mining.cpp Show resolved Hide resolved
@MarcoFalke MarcoFalke changed the title refactor: Remove unused COINBASE_FLAGS rpc: Remove unused COINBASE_FLAGS Nov 19, 2019
@laanwj
Copy link
Member

@laanwj laanwj commented Nov 20, 2019

ACK 9aedabe
ACK e9a27cf

@narula
Copy link
Member Author

@narula narula commented Nov 20, 2019

I can update RPCHelpMan. Is the right way to do that just remove flags, or would you prefer it to be marked in some way?

Does it make sense to remove the coinbaseaux flag as well?

@laanwj
Copy link
Member

@laanwj laanwj commented Nov 20, 2019

I can update RPCHelpMan. Is the right way to do that just remove flags, or would you prefer it to be marked in some way?

To remove it, so that the help matches the output.

Does it make sense to remove the coinbaseaux flag as well?

It's part of the BIP according to @luke-jr so I think it'd be better to keep it but leave it empty, as @MarcoFalke says.

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Nov 20, 2019

utACK 9aedabe once flags has been removed from the help text.

Commit d449772 stopped setting
COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.
Update the help string to remove "flags", which is not specified in
BIP 22.
@narula
Copy link
Member Author

@narula narula commented Nov 21, 2019

Updated to remove flags.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Nov 21, 2019

ACK e9a27cf 💻

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK e9a27cf338dc618b8ecab8984abc54d588de8a05 💻
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUhjIQwAsMub4O7fZgenPS9fKJMwQxcxAS+hoZOFtDsGFN2pBFSCgB4oJE5c4u7T
OrTw53bux7AuRuhDjw7oTEp7Gv1J3IIR1dWP0Rnh5Pxjt2cPaoHElTHFWLqoR9tE
n2y7yTsqo2GSTze1JraibYW9CJY7v0ZS2SvrjCfhBR0ybYXKRKnGVFmPuVE2HwTl
jrBZklNRgL9ft/b0azemSXOuI8oy6OsBX56XOaiRGZ/RD7A32QspoePiSPqK1eqP
tHPEvH7BQkeGEVq2pTrdvMkkSbGplIZB3YI7TYzIyEGS2DWa9Kx/ERFCs1NFckP5
axmMc9DIgb+DYfPLx6Rj9YsY0CdQajRX9wmPGNIV04sUcwD19Q3gUE1Q14Ockq3u
9T4es3ppRDqvpXmMhuQMZy899NzLMrgtGx4qLJaFkSNTDZsA2JQdI3lD+uGuCu9D
x1a+ecpAg+UtSXTal3bIu861TgU0npszmJ+3OD37IknfA4vxeHTmPfo5xrYbPOSE
dc28Zx+w
=6gag
-----END PGP SIGNATURE-----

Timestamp of file with hash 4af5f8707e419046118b148a954e705aa3ec85e3d60b38b9f3a0e1e32ec1cb31 -

laanwj added a commit that referenced this issue Nov 22, 2019
e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula)

Pull request description:

  Commit d449772 stopped setting
  COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.

  Following up on #17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig.

ACKs for top commit:
  laanwj:
    ACK e9a27cf
  MarcoFalke:
    ACK e9a27cf 💻

Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334
@laanwj laanwj merged commit e9a27cf into bitcoin:master Nov 22, 2019
2 checks passed
sidhujag pushed a commit to syscoin/syscoin that referenced this issue Nov 22, 2019
e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula)

Pull request description:

  Commit d449772 stopped setting
  COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.

  Following up on bitcoin#17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig.

ACKs for top commit:
  laanwj:
    ACK e9a27cf
  MarcoFalke:
    ACK e9a27cf 💻

Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this issue Nov 29, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Nov 5, 2020
Summary:
> Commit d449772 stopped setting
> COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.
> Update the help string to remove "flags", which is not specified in
> BIP 22.
One occurence of `flags` in the help message was already removed in D8124

This is a backport of Core [[bitcoin/bitcoin#17519 | PR17519]]

Test Plan:
Verify that nothing is broken as a result of removing `pushKV("flags"...`
`ninja all check-all`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8275
sidhujag pushed a commit to syscoin-core/syscoin that referenced this issue Nov 10, 2020
e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula)

Pull request description:

  Commit d449772 stopped setting
  COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.

  Following up on bitcoin#17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig.

ACKs for top commit:
  laanwj:
    ACK e9a27cf
  MarcoFalke:
    ACK e9a27cf 💻

Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Aug 29, 2021
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Aug 29, 2021
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Aug 29, 2021
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 29, 2021
…oin#18612: script: Remove undocumented and unused operator+

ccccd51 script: Remove undocumented and unused operator+ (MarcoFalke)

Pull request description:

  This operator has no documented use case and is also unused outside of test code. The test code and all other (imaginary) code that might use this operator is written more clear and concise by the existing CScript push operators for opcodes and data.

  Removing the operator is also going to protect against accidentally reintroducing bugs like this bitcoin@6ff5f71#diff-8458adcedc17d046942185cb709ff5c3L1135 (last time it was used).

ACKs for top commit:
  laanwj:
    ACK ccccd51

Tree-SHA512: 43898ac77e4d9643d9f8ac6f8f65497a4f0bbb1fb5dcaecc839c3719aa36181ba77befb213e59a9f33a20a29e0173a0e9c4763b1930940b32c3d1598b3e39af9
vijaydasmp added a commit to vijaydasmp/dash that referenced this issue Aug 30, 2021
vijaydasmp pushed a commit to vijaydasmp/dash that referenced this issue Aug 30, 2021
e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula)

Pull request description:

  Commit d449772 stopped setting
  COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.

  Following up on bitcoin#17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig.

ACKs for top commit:
  laanwj:
    ACK e9a27cf
  MarcoFalke:
    ACK e9a27cf 💻

Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334
PastaPastaPasta added a commit to dashpay/dash that referenced this issue Aug 31, 2021
* Merge bitcoin#17519: rpc: Remove unused COINBASE_FLAGS

e9a27cf refactor: Remove unused COINBASE_FLAGS (Neha Narula)

Pull request description:

  Commit d449772 stopped setting
  COINBASE_FLAGS, and it looks like it hasn't been used since P2SH.

  Following up on bitcoin#17489, remove COINBASE_FLAGS which is unused. I verified that removing this did not change the contents of the coinbase's scriptSig.

ACKs for top commit:
  laanwj:
    ACK e9a27cf
  MarcoFalke:
    ACK e9a27cf 💻

Tree-SHA512: f9dac124ce7e3edcae974137764bb5039387b1b123b86af44486e398aa4a8d91a9ecf640e207b364ae303acbbaee7cca300d303ea3d6869ba9cae2bf555a6334

* Update src/rpc/mining.cpp

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>

Co-authored-by: Wladimir J. van der Laan <laanwj@protonmail.com>
Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants