Split off CBlockHeader from CBlock #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
|
Good idea. |
Cleaner and removes the need for the application-specific flags in serialize.h.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e754cf4133c9c97e320ae5dec394e338524e650b for binaries and test log. |
sipa
added a commit
that referenced
this pull request
Nov 24, 2012
Split off CBlockHeader from CBlock
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
Split off CBlockHeader from CBlock
KolbyML
pushed a commit
to KolbyML/bitcoin
that referenced
this pull request
Dec 5, 2020
…eateTransaction flow. c4cbcd4 [Wallet] CreateTransaction: Removing an age check (an a unneeded loop over all of the available coins) that was there solely for the free transactions calculations which we don't have. (furszy) 781e68a [Wallet] Remove unused fSplitBlock functionality. (furszy) Pull request description: Removed unused and redundant flows from `CWallet::CreateTransaction`. Like the utxo splitter that isn't used anywhere and the coin age calculation that was previously being used for free transaction calculation (which we don't have anymore). It will speedup the transaction creation process for v1 transactions removing one loop over all of the available utxo and help on the v1-v2 transaction creation processes unification goal. ACKs for top commit: random-zebra: utACK c4cbcd4 Tree-SHA512: 459dd5dcecc34473de31c77aec4aeebeb2deef837d5b212df84b219dc568fa9e7bb6ebf4c825f9644cce7b1872abdf3280bb366a5db9a6fca2bc8c81d4c5126a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner and removes the need for the application-specific flags in serialize.h.
No semantic changes.