depends: Improve id string robustness #20629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
Concept ACK. If I understand it correctly, this includes only specific targeted environment variables and not the entire env? |
|
|
Yes! It automatically includes any env var that starts with the name of the tool (e.g. |
Right, perhaps someone knows a better invocation here? I'm guessing |
dongcarl
force-pushed
the
2020-12-improve-depends-id-string
branch
2 times, most recently
from
4b9aaca to
f792069
Compare
|
Code review ACK f792069 |
Gitian builds
|
Previously, if the value contained syntax that was meaningful to make, the printing would fail. Quoting properly avoids this.
Environment variables and search paths can drastically effect the operation of build tools. Include these in our id string to mitigate against false cache hits.
dongcarl
force-pushed
the
2020-12-improve-depends-id-string
branch
from
f792069 to
5200929
Compare
This was referenced Feb 5, 2021
laanwj
changed the title
15 tasks
|
re-ACK 5200929 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 15, 2021
5200929 depends: Include GUIX_ENVIRONMENT in id string (Carl Dong) 4c7d418 depends: Improve id string robustness (Carl Dong) b3bdff4 build: Proper quoting for var printing targets (Carl Dong) Pull request description: ``` Environment variables and search paths can drastically effect the operation of build tools. Include these in our id string to mitigate against false cache hits. ``` Note to builders: This will invalidate all depends output caches in `BASE_CACHE` ACKs for top commit: laanwj: re-ACK 5200929 Tree-SHA512: e70c98da89cde90dc54bc3be89b925787cf94bbf246e27cc9345816b312073d78a02215448f731f21d8cf033c455234a2377ff1d66c00e1f3db69c9c9687d027
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to builders: This will invalidate all depends output caches in
BASE_CACHE