Add -lboost_chrono to both the qt .pro file and makefile.unix #2493

robbak · 2013-04-09T11:07:30Z

On FreeBSD, I was unable to build any version since the MicroSleep() change (commit 1b43bf0), which created a dependency on boost_chrono for boost versions above 1.50. This dependency had never been added to either makefile.unix or bitcoin-qt.pro.

This pullreq adds the required -lboost_chrono to both files.

Diapolo · 2013-04-09T12:40:30Z

bitcoin-qt.pro

@@ -400,7 +400,7 @@ LIBS += $$join(BOOST_LIB_PATH,,-L,) $$join(BDB_LIB_PATH,,-L,) $$join(OPENSSL_LIB
 LIBS += -lssl -lcrypto -ldb_cxx$$BDB_LIB_SUFFIX
 # -lgdi32 has to happen after -lcrypto (see  #681)
 win32:LIBS += -lws2_32 -lshlwapi -lmswsock -lole32 -loleaut32 -luuid -lgdi32
-LIBS += -lboost_system$$BOOST_LIB_SUFFIX -lboost_filesystem$$BOOST_LIB_SUFFIX -lboost_program_options$$BOOST_LIB_SUFFIX -lboost_thread$$BOOST_THREAD_LIB_SUFFIX
+LIBS += -lboost_system$$BOOST_LIB_SUFFIX -lboost_filesystem$$BOOST_LIB_SUFFIX -lboost_program_options$$BOOST_LIB_SUFFIX -lboost_thread$$BOOST_THREAD_LIB_SUFFIX -lboost_chrono$$BOOST_LIB_SUFFIX
 win32:LIBS += -lboost_chrono$$BOOST_LIB_SUFFIX


We have that dependency in for Windows :D. You need to remove this one then, if the lib should be available for all OSes.

being added generally. (Thanks Phillip Kaufmann)

- don't display "Bitcoin - " when no title was supplied but just "Bitcoin"

BitcoinPullTester · 2013-04-11T15:05:25Z

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/9736430b85d8bc5ce0e742344cf2f525a79c6246 for binaries and test log.

This could happen for one of several reasons:

It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (you can find the patches applied at test-time at http://jenkins.bluematt.me/pull-tester/files/patches/)
It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
It does not build on either Linux i386 or Win32 (via MinGW cross compile)
The test suite fails on either Linux i386 or Win32
The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

GUI can't connect to RPC. Showing this option in the help confuses people, so remove it.

Every block index entry currently requires a separately-allocated CBigNum. By replacing them with uint256, it's just 32 bytes extra in CBlockIndex itself. This should save us a few megabytes in RAM, and less allocation overhead.

…nect qt: don't show rpcconnect command line option in help

Use a uint256 for bnChainWork

sipa · 2013-04-12T20:59:10Z

I'm afraid this will have to be conditional on the version of Boost used.

robbak · 2013-04-12T21:18:33Z

Ok. I'll look at this further. Is the reason for the windows inclusion of
this library also because of boost library version?
On 13/04/2013 6:59 AM, "Pieter Wuille" notifications@github.com wrote:

I'm afraid this will have to be conditional on the version of Boost used.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2493#issuecomment-16317293
.

luke-jr · 2013-04-12T21:30:11Z

Note the pullreq to upgrade boost to 1.53 removed the chronos lib.

Diapolo · 2013-04-12T23:27:14Z

@luke-jr I know that my dependecy lib pull needs updates to reflect this.

Diapolo · 2013-04-12T23:27:46Z

@robbak Windows needed the chrono lib because we use Boost 1.50.

robbak · 2013-04-13T04:50:45Z

On 13/04/2013 6:59 AM, "Pieter Wuille" notifications@github.com wrote:

I'm afraid this will have to be conditional on the version of Boost used.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2493#issuecomment-16317293
.

Time for a silly question: How do we make this conditional on library
version? We aren't doing this anywhere else in the makefile or .pro file,
and the documentation doesn't seem to advertise a method.

For my purposes on FreeBSD, I can easily handle this in our port makefile -
it's easy to add it to LIBS or QMAKE_LFLAGS until we get an updated boost.

luke-jr · 2013-04-13T05:38:00Z

This is why automake was invented... :p

laanwj · 2013-04-13T09:23:16Z

Configure script: #2195
I think we're going to need it.

qt: move export button to tabs

Bitcoin-Qt: remove " - " on empty title in BitcoinGUI::message()

being added generally. (Thanks Phillip Kaufmann)

into add_boost_chrono_lib

BitcoinPullTester · 2013-04-14T09:28:07Z

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/e622f35d2d3de667006b9c171928e36911aadef9 for binaries and test log.

This could happen for one of several reasons:

It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in contrib/test-scripts)
It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
It does not build on either Linux i386 or Win32 (via MinGW cross compile)
The test suite fails on either Linux i386 or Win32
The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

robbak · 2013-04-14T09:34:11Z

OK, that was jut me doing a merge. Sorry for the noise.

I'll close this. By the time we have a configuration script, We'll have an updated boost, and will no longer need it.

There is someone else on the mailing list that has had the same problem on a linux variant, too.

Another work-around may be adjusting the code to not use boost_chrone below boost version 5.3. I personally would rather add the lib for boost 5.0~5.3. Maybe a note in the makefile, like the notes we have for other boost versions.

Add -lboost_chrono to both the qt .pro file and makefile.unix

5281f99

Diapolo reviewed Apr 9, 2013
View reviewed changes

robbak and others added 2 commits April 10, 2013 13:54

Remove explicit adding of this library for win32 if it is being

9736430

being added generally. (Thanks Phillip Kaufmann)

Bitcoin-Qt: remove " - " on empty title in BitcoinGUI::message()

8d643c9

- don't display "Bitcoin - " when no title was supplied but just "Bitcoin"

laanwj and others added 4 commits April 11, 2013 22:29

qt: don't show rpcconnect command line option in help

212b42c

GUI can't connect to RPC. Showing this option in the help confuses people, so remove it.

Use a uint256 for bnChainWork

1657c4b

Every block index entry currently requires a separately-allocated CBigNum. By replacing them with uint256, it's just 32 bytes extra in CBlockIndex itself. This should save us a few megabytes in RAM, and less allocation overhead.

Merge pull request bitcoin#2513 from laanwj/2013_04_gui_remove_rpccon…

dce6f42

…nect qt: don't show rpcconnect command line option in help

Merge pull request bitcoin#2418 from sipa/uintwork

1b4b463

Use a uint256 for bnChainWork

laanwj and others added 5 commits April 13, 2013 05:39

Merge pull request bitcoin#2515 from laanwj/2013_04_move_exportbutton

f81b678

qt: move export button to tabs

Merge pull request bitcoin#2492 from Diapolo/Qt_message

ac89a1e

Bitcoin-Qt: remove " - " on empty title in BitcoinGUI::message()

Add -lboost_chrono to both the qt .pro file and makefile.unix

e16ab32

Remove explicit adding of this library for win32 if it is being

171bb72

being added generally. (Thanks Phillip Kaufmann)

Merge branch 'add_boost_chrono_lib' of https://github.com/robbak/bitcoin

e622f35

into add_boost_chrono_lib

robbak closed this Apr 14, 2013

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add -lboost_chrono to both the qt .pro file and makefile.unix #2493

Add -lboost_chrono to both the qt .pro file and makefile.unix #2493

Uh oh!

robbak commented Apr 9, 2013

Uh oh!

Diapolo Apr 9, 2013

Uh oh!

BitcoinPullTester commented Apr 11, 2013

Uh oh!

sipa commented Apr 12, 2013

Uh oh!

robbak commented Apr 12, 2013

Uh oh!

luke-jr commented Apr 12, 2013

Uh oh!

Diapolo commented Apr 12, 2013

Uh oh!

Diapolo commented Apr 12, 2013

Uh oh!

robbak commented Apr 13, 2013

Uh oh!

luke-jr commented Apr 13, 2013

Uh oh!

laanwj commented Apr 13, 2013

Uh oh!

BitcoinPullTester commented Apr 14, 2013

Uh oh!

robbak commented Apr 14, 2013

Uh oh!

Uh oh!

Add -lboost_chrono to both the qt .pro file and makefile.unix #2493

Add -lboost_chrono to both the qt .pro file and makefile.unix #2493

Uh oh!

Conversation

robbak commented Apr 9, 2013

Uh oh!

Diapolo Apr 9, 2013

Choose a reason for hiding this comment

Uh oh!

BitcoinPullTester commented Apr 11, 2013

Uh oh!

sipa commented Apr 12, 2013

Uh oh!

robbak commented Apr 12, 2013

Uh oh!

luke-jr commented Apr 12, 2013

Uh oh!

Diapolo commented Apr 12, 2013

Uh oh!

Diapolo commented Apr 12, 2013

Uh oh!

robbak commented Apr 13, 2013

Uh oh!

luke-jr commented Apr 13, 2013

Uh oh!

laanwj commented Apr 13, 2013

Uh oh!

BitcoinPullTester commented Apr 14, 2013

Uh oh!

robbak commented Apr 14, 2013

Uh oh!

Uh oh!