Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop untrusted bpfcc tool usage #27510

Closed
wants to merge 2 commits into from

Conversation

fanquake
Copy link
Member

Followup to #27360, where we migrated this job to Ubuntu 23.04, which ships with newer versions of the tools: https://packages.ubuntu.com/lunar/bpfcc-tools.

@fanquake fanquake requested a review from 0xB10C April 21, 2023 14:25
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 21, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept ACK 0xB10C, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #27084 (ci: A few fixes of ccache issues by hebasto)
  • #25797 (build: Add CMake-based build system by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot added the Tests label Apr 21, 2023
Copy link
Contributor

@0xB10C 0xB10C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big Concept ACK!

.cirrus.yml Outdated Show resolved Hide resolved
Followup to bitcoin#27360, where we migrated this job to Ubuntu 23.04, which
ships with newer versions of the tools:
https://packages.ubuntu.com/lunar/bpfcc-tools.
@hebasto
Copy link
Member

hebasto commented Apr 21, 2023

Concept ACK.

@fanquake
Copy link
Member Author

Combined into #27360. See #27360 (comment).

@fanquake fanquake closed this Apr 27, 2023
@fanquake fanquake deleted the drop_untrusted_bpfcc_tools branch April 27, 2023 12:48
@bitcoin bitcoin locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants