Strictly hash what is going to be signed #4695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Dependent on #4692 |
|
Rebased on top of #4754 |
|
Rebased on top of #4755 |
jtimon
force-pushed
the
nohash2
branch
3 times, most recently
from
d8712a7 to
b0997d9
Compare
|
Closing until #4754 is merged. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4695_9aaf3b6c02e746d7db17ab260837f8736c99f4f0/ for binaries and test log. |
|
I think I've changed my mind, at least on removing SignN. Closing for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #4694.
Again, more important than the optimization, I think the end result is more readable.
It could be a little bit nicer by joining SignHash and Sign, but then multisig's performance would be hurt.