Skip to content

Conversation

jonasschnelli
Copy link
Contributor

No description provided.

@fanquake
Copy link
Member

fanquake commented Feb 4, 2015

screen shot

@jonasschnelli
Copy link
Contributor Author

Now it should be Qt4 compatible.

Screen before and after:
bildschirmfoto 2015-02-04 um 20 32 31

bildschirmfoto 2015-02-04 um 20 34 19

@jonasschnelli jonasschnelli force-pushed the 2015/01/qt_about branch 2 times, most recently from c259586 to 17aeb79 Compare February 4, 2015 19:43
@jonasschnelli
Copy link
Contributor Author

Linux:

Before
bildschirmfoto 2015-02-04 um 20 46 24

After:
bildschirmfoto 2015-02-04 um 21 00 28

@paveljanik
Copy link
Contributor

ACK
minor NIT: on testnet/regtest, the color is not as we are used to :-)

@jonasschnelli
Copy link
Contributor Author

@paveljanik Yes. This is a feature ... cough slightly.
Having a blue/green icon in testnet/regtest mode is fine IMO.

@paveljanik
Copy link
Contributor

BTW - I was talking about the color of the new added icon on the About window... I like the color of the intro image (both green and blue one!). Would like to see the same color in the About window as well :-)
But you can safely ignore this :-)

@jonasschnelli
Copy link
Contributor Author

@paveljanik Yes. I know what you meant with that. I was just cough slightly because i was aware of this inconsistence. It would certainly be fixable somehow. But the color of the icon gets rewritten and cached at the very beginning of the qt app cycle.
I think it's not worth the effort because the green/blue icon will probably only popups on devs screens.

@paveljanik
Copy link
Contributor

Agreed, sure.

@fanquake
Copy link
Member

fanquake commented Feb 5, 2015

Tested ACK

@laanwj laanwj added the GUI label Feb 5, 2015
@ghost
Copy link

ghost commented Feb 7, 2015

First time commenting on a project so I hope I'm doing this correctly and I apologize if this is a stupid question, but is there any effect vis a vis resizing the window with the new image?

@jonasschnelli
Copy link
Contributor Author

@L-Cranston-Shadow First github comment. Nice. Thanks for your participation.
The resize behavior is still the same.
You can still resize the window to a very small size (see below).
In the current (0.9.3) and upcoming version 0.10 there is also a image on the about screen which follows the same resize constraints.

Feel free to test it by building bitcoin master yourself of use a prebuilt binary (https://builds.jonasschnelli.ch/pulls/5753/).

bildschirmfoto 2015-02-07 um 13 07 26

@laanwj laanwj merged commit d67a642 into bitcoin:master Feb 9, 2015
laanwj added a commit that referenced this pull request Feb 9, 2015
d67a642 [Qt] add bitcoin logo to about screen (Jonas Schnelli)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants