Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add a BasicTestingSetup and apply to all tests #5883

Merged
merged 1 commit into from Mar 12, 2015

Conversation

@laanwj
Copy link
Member

commented Mar 12, 2015

Make sure that chainparams and logging is properly initialized. Doing this for every test may be overkill, but this initialization is so simple that that does not matter.

This should fix the travis issues.

tests: add a BasicTestingSetup and apply to all tests
Make sure that chainparams and logging is properly initialized. Doing
this for every test may be overkill, but this initialization is so
simple that that does not matter.

This should fix the travis issues.

@laanwj laanwj force-pushed the laanwj:2015_03_fix_test_scattering branch to 92fd887 Mar 12, 2015

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Mar 12, 2015

Tested locally. Worked fine.
Let's see what travis means. Also started a gitian build to get more test env. diversity.

@laanwj laanwj added the Tests label Mar 12, 2015

@Diapolo

This comment has been minimized.

Copy link

commented Mar 12, 2015

This doesn't apply to Qt tests?

@laanwj

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2015

@Diapolo I don't think so, nothing changed there recently did it?

@Diapolo

This comment has been minimized.

Copy link

commented Mar 12, 2015

I was just asking, because it seems you updated all core testfiles, but not the Qt ones.

@laanwj

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2015

@Diapolo Just checked. Last change to qt tests is 5 weeks ago and had to do with payment requests. There were no test reordering or initialization changes for qt.

@Diapolo

This comment has been minimized.

Copy link

commented Mar 12, 2015

Alright, thanks for verifying :)!

@laanwj laanwj merged commit 92fd887 into bitcoin:master Mar 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Mar 12, 2015
Merge pull request #5883
92fd887 tests: add a BasicTestingSetup and apply to all tests (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.