tests: add a BasicTestingSetup and apply to all tests #5883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that chainparams and logging is properly initialized. Doing this for every test may be overkill, but this initialization is so simple that that does not matter. This should fix the travis issues.
laanwj
force-pushed
the
2015_03_fix_test_scattering
branch
from
9a22993 to
92fd887
Compare
|
Tested locally. Worked fine. |
|
This doesn't apply to Qt tests? |
|
@Diapolo I don't think so, nothing changed there recently did it? |
|
I was just asking, because it seems you updated all core testfiles, but not the Qt ones. |
|
@Diapolo Just checked. Last change to qt tests is 5 weeks ago and had to do with payment requests. There were no test reordering or initialization changes for qt. |
|
Alright, thanks for verifying :)! |
laanwj
added a commit
that referenced
this pull request
Mar 12, 2015
92fd887 tests: add a BasicTestingSetup and apply to all tests (Wladimir J. van der Laan)
|
For the records. Gitian was also happy with this: |
Merged
This was referenced Mar 13, 2015
This was referenced Feb 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that chainparams and logging is properly initialized. Doing this for every test may be overkill, but this initialization is so simple that that does not matter.
This should fix the travis issues.