Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to use -debug=1 to enable all debugging #6164

Merged
merged 3 commits into from Jun 1, 2015

Conversation

@lpescher
Copy link
Contributor

lpescher commented May 20, 2015

This is more consistent with other command line arguments and more intuitive. Originally, a user would specify "-debug=" to enable all debugging; which still works. The documentation and --help pages are also updated

Addresses Issue #4219

lpescher added 3 commits May 20, 2015
…r options

Most people expect a value of 1 to enable all for command line arguments.
However to do this for the -debug option you must type "-debug=".
This has been changed to allow "-debug=1" as well as "-debug=" to
enable all debug logging
@jonasschnelli
Copy link
Member

jonasschnelli commented May 20, 2015

tested ACK.

I think this make sense. -debug=1 should act the same as -debug.

@laanwj
Copy link
Member

laanwj commented May 20, 2015

utACK - I'd prefer if you squash this into one commit as all three changes form one atomic whole.

@laanwj laanwj added the Refactoring label May 20, 2015
@fanquake
Copy link
Member

fanquake commented May 20, 2015

ACK after squashing

On Wednesday, May 20, 2015, Wladimir J. van der Laan <
notifications@github.com> wrote:

utACK - I'd prefer if you squash this into one commit as all three changes
form one atomic whole.

Reply to this email directly or view it on GitHub
#6164 (comment).

@laanwj laanwj merged commit aa41bc8 into bitcoin:master Jun 1, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jun 1, 2015
aa41bc8 Update help message to match the #4219 change (lpescher)
f60bb5e Update documentation to match the #4219 change (lpescher)
cb87386 Make command line option to show all debugging consistent with similar options (lpescher)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.