Allow user to use -debug=1 to enable all debugging #6164

Merged
merged 3 commits into from Jun 1, 2015

Conversation

Projects
None yet
4 participants
@lpescher
Contributor

lpescher commented May 20, 2015

This is more consistent with other command line arguments and more intuitive. Originally, a user would specify "-debug=" to enable all debugging; which still works. The documentation and --help pages are also updated

Addresses Issue #4219

lpescher added some commits May 20, 2015

Make command line option to show all debugging consistent with simila…
…r options

Most people expect a value of 1 to enable all for command line arguments.
However to do this for the -debug option you must type "-debug=".
This has been changed to allow "-debug=1" as well as "-debug=" to
enable all debug logging
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli May 20, 2015

Member

tested ACK.

I think this make sense. -debug=1 should act the same as -debug.

Member

jonasschnelli commented May 20, 2015

tested ACK.

I think this make sense. -debug=1 should act the same as -debug.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 20, 2015

Member

utACK - I'd prefer if you squash this into one commit as all three changes form one atomic whole.

Member

laanwj commented May 20, 2015

utACK - I'd prefer if you squash this into one commit as all three changes form one atomic whole.

@laanwj laanwj added the Refactoring label May 20, 2015

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 20, 2015

Member

ACK after squashing

On Wednesday, May 20, 2015, Wladimir J. van der Laan <
notifications@github.com> wrote:

utACK - I'd prefer if you squash this into one commit as all three changes
form one atomic whole.

Reply to this email directly or view it on GitHub
#6164 (comment).

Member

fanquake commented May 20, 2015

ACK after squashing

On Wednesday, May 20, 2015, Wladimir J. van der Laan <
notifications@github.com> wrote:

utACK - I'd prefer if you squash this into one commit as all three changes
form one atomic whole.

Reply to this email directly or view it on GitHub
#6164 (comment).

@laanwj laanwj merged commit aa41bc8 into bitcoin:master Jun 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 1, 2015

Merge pull request #6164
aa41bc8 Update help message to match the #4219 change (lpescher)
f60bb5e Update documentation to match the #4219 change (lpescher)
cb87386 Make command line option to show all debugging consistent with similar options (lpescher)

@dagurval dagurval referenced this pull request in bitcoinxt/bitcoinxt Apr 23, 2017

Merged

Util ports #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment