MOVEONLY: Policy: Move some policy code #6335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtimon
force-pushed
the
policy-moveonly-0.11.99
branch
from
4bc158f to
830e636
Compare
|
Code Review ACK. |
|
utACK (mostly concept ACK, w/ some code review) |
|
utACK |
|
Confirmed move-only other than the std namespace changes. utACK other than the nit above. |
|
@theuni re additional declaration. It was to not leave the comment alone until it is replaced with the CStandardPolicy method that will replace it in jtimon@3fdcfed#diff-d22bc3e058f8982972e2eb381a1df668L35 but I'm happy to remove that line if it doesn't make sense to anyone else. For me having the comment ready there is enough. |
|
utACK, needs rebase |
|
ACK (before the merge conflict) |
- [script/standard.o] IsStandard - [main.o] IsStandardTx - [main.o] AreInputsStandard Also, don't use namespace std in policy.cpp
jtimon
force-pushed
the
policy-moveonly-0.11.99
branch
from
2927ec8 to
9238ecb
Compare
|
Rebased |
|
Concept ACK (did not confirm MOVEONLY since there are other ACKs here). |
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Dec 17, 2019
Bitcoin script PRs 1 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6335 - bitcoin/bitcoin#6424 - bitcoin/bitcoin#11058 - bitcoin/bitcoin#12460 - bitcoin/bitcoin#13194 Part of #2074.
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Jun 27, 2020
5d96c91 add missing policy.cpp file to cmake (furszy) 2d0783d Standard Solver(): Include cold staking template matching. (furszy) b7fe4c0 Remove template matching and pseudo opcodes (furszy) fe31b31 Assert CPubKey::ValidLength to the pubkey's header-relevent size (Ben Woosley) 2f6b249 Make TX_SCRIPTHASH clear vSolutionsRet first (Peter Todd) 45e5102 Policy: MOVEONLY: 3 functions to policy (furszy) 2c7da7f Policy: MOVEONLY: Create policy/policy.h with some constants (furszy) Pull request description: Coming from the following PRs (with small customizations for our features): * bitcoin#6335 * bitcoin#6424 * bitcoin#12460 * bitcoin#13194 ACKs for top commit: random-zebra: Looking good. ACK 5d96c91 Fuzzbawls: ACK 5d96c91 Tree-SHA512: b3e7479864e16942682b9bc19f432b2a657561647eeadf0ef1285651feb05875d295ff530582ebbc8edacaf3c7d3888249513b4a93d871c2d6c2e1b157ace8c8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move policy code out of main (and policy/standard).
Nobody seemed to disagree with this part in any of the multiple versions of #6068 and related PRs.
This is trivially non-risky, but this PR will be closed when a bitcoin/0.12 branch is created (unless it has been merged first).