Clear strMiscWarning before running PartitionAlert#6888
Merged
Conversation
…pp and initialize strMiscWarning before calling PartitionCheck()."
Member
|
Agree strMiscWarning is terrible, see also #6809 |
Contributor
|
ACK |
Contributor
|
Tested ACK |
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
Oct 26, 2015
143d173 Use BOOST_CHECK_MESSAGE() rather than BOOST_CHECK() in alerts_tests.cpp and initialize strMiscWarning before calling PartitionCheck()." (Eric Lombrozo)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jan 9, 2016
…pp and initialize strMiscWarning before calling PartitionCheck()." Github-Pull: bitcoin#6888 Rebased-From: 143d173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting strange travis errors earlier because some test that was running prior to PartitionAlert in alert_tests apparently was setting the strMiscWarning variable. Using a side effect such as this as an error handling mechanism is probably not a very good idea to begin with...but if we're going to do this, we should make sure to reset the variable before each call so we can tell which one set it.
Note: The implication here is that something before the call on line 224 is setting this variable and we can't easily figure out what it is...which should probably also be fixed.