Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark sanity checks and fork checks in ConnectBlock #6965

Merged
merged 1 commit into from Nov 10, 2015

Conversation

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Nov 6, 2015

Add new fields to benchmarking ConnectBlock. In my very basic tests "Sanity checks" uses ~10x "Callbacks" and "Index writing" combined and "Fork Checks" uses about 1/3 the time of connecting transactions!

@TheBlueMatt
Copy link
Contributor Author

TheBlueMatt commented Nov 6, 2015

Note that the second should use much less time with #6931, though I havent tested it yet.

@sipa
Copy link
Member

sipa commented Nov 7, 2015

Concept & code review ACK.

@gmaxwell
Copy link
Contributor

gmaxwell commented Nov 7, 2015

ACK.

@laanwj laanwj added the Validation label Nov 10, 2015
@laanwj laanwj merged commit 77f1f59 into bitcoin:master Nov 10, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Nov 10, 2015
77f1f59 Benchmark sanity checks and fork checks in ConnectBlock (Matt Corallo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.