Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBenchmark sanity checks and fork checks in ConnectBlock #6965
Conversation
|
Note that the second should use much less time with #6931, though I havent tested it yet. |
|
Concept & code review ACK. |
|
ACK. |
laanwj
added a commit
that referenced
this pull request
Nov 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
TheBlueMatt commentedNov 6, 2015
Add new fields to benchmarking ConnectBlock. In my very basic tests "Sanity checks" uses ~10x "Callbacks" and "Index writing" combined and "Fork Checks" uses about 1/3 the time of connecting transactions!