Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upBenchmark sanity checks and fork checks in ConnectBlock #6965
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
TheBlueMatt
Nov 6, 2015
Contributor
Note that the second should use much less time with #6931, though I havent tested it yet.
|
Note that the second should use much less time with #6931, though I havent tested it yet. |
TheBlueMatt
referenced this pull request
Nov 6, 2015
Merged
Skip BIP 30 verification where not necessary #6931
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Concept & code review ACK. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
ACK. |
laanwj
added
the
Validation
label
Nov 10, 2015
laanwj
merged commit 77f1f59
into
bitcoin:master
Nov 10, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
added a commit
that referenced
this pull request
Nov 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TheBlueMatt commentedNov 6, 2015
Add new fields to benchmarking ConnectBlock. In my very basic tests "Sanity checks" uses ~10x "Callbacks" and "Index writing" combined and "Fork Checks" uses about 1/3 the time of connecting transactions!