Benchmark sanity checks and fork checks in ConnectBlock #6965

Merged
merged 1 commit into from Nov 10, 2015

Conversation

Projects
None yet
4 participants
@TheBlueMatt
Contributor

TheBlueMatt commented Nov 6, 2015

Add new fields to benchmarking ConnectBlock. In my very basic tests "Sanity checks" uses ~10x "Callbacks" and "Index writing" combined and "Fork Checks" uses about 1/3 the time of connecting transactions!

@TheBlueMatt

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Nov 6, 2015

Contributor

Note that the second should use much less time with #6931, though I havent tested it yet.

Contributor

TheBlueMatt commented Nov 6, 2015

Note that the second should use much less time with #6931, though I havent tested it yet.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Nov 7, 2015

Member

Concept & code review ACK.

Member

sipa commented Nov 7, 2015

Concept & code review ACK.

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Nov 7, 2015

Member

ACK.

Member

gmaxwell commented Nov 7, 2015

ACK.

@laanwj laanwj added the Validation label Nov 10, 2015

@laanwj laanwj merged commit 77f1f59 into bitcoin:master Nov 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Nov 10, 2015

Merge pull request #6965
77f1f59 Benchmark sanity checks and fork checks in ConnectBlock (Matt Corallo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment