Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Don't set strMiscWarning on every exception #7114

Merged
merged 1 commit into from Nov 27, 2015

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented Nov 27, 2015

Fixes #6809 - run-of-the-mill exceptions should not get into strMiscWarning (which is reported by getinfo).

Edit: after this we could move strMiscWarning out of util, as it's not used there anymore. But it's not clear to where.

Fixes bitcoin#6809 - run-of-the-mill exceptions should not get into
strMiscWarning (which is reported by `getinfo`).
@MarcoFalke
Copy link
Member

MarcoFalke commented Nov 27, 2015

utACK 9b63758

@jgarzik
Copy link
Contributor

jgarzik commented Nov 27, 2015

ut ACK

@laanwj laanwj merged commit 9b63758 into bitcoin:master Nov 27, 2015
laanwj added a commit that referenced this pull request Nov 27, 2015
9b63758 util: Don't set strMiscWarning on every exception (Wladimir J. van der Laan)
zkbot added a commit to zcash/zcash that referenced this pull request Feb 21, 2020
Upstream PRs relating to strMiscWarning

This pulls in upstream PRs bitcoin/bitcoin#7114 and bitcoin/bitcoin#9236 (non-QT parts).

* Fixes bitcoin/bitcoin#6809 - run-of-the-mill exceptions should not get into `strMiscWarning` (which is reported by `getinfo`).
* Eliminate data races for `strMiscWarning` and `fLargeWork*Found`. This moves all access to these data structures through accessor functions and protects them with a lock.
denverbdr pushed a commit to ycashfoundation/ycash that referenced this pull request Mar 6, 2020
Upstream PRs relating to strMiscWarning

This pulls in upstream PRs bitcoin/bitcoin#7114 and bitcoin/bitcoin#9236 (non-QT parts).

* Fixes bitcoin/bitcoin#6809 - run-of-the-mill exceptions should not get into `strMiscWarning` (which is reported by `getinfo`).
* Eliminate data races for `strMiscWarning` and `fLargeWork*Found`. This moves all access to these data structures through accessor functions and protects them with a lock.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in ProcessMessages should not end up in getinfo errors
3 participants