[Backport 0.12][RPC] quickfix for RPC timer interface problem #7318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
jonasschnelli
changed the title
|
utACK daa8da2 |
|
Tested ACK 9490ec3 (which should be similar to daa8da2), indeed fixes #7316 (comment). |
|
utACK |
laanwj
added a commit
that referenced
this pull request
Jan 8, 2016
daa8da2 Backport: quickfix for RPC timer interface problem (Jonas Schnelli)
|
In the future, please put these kind of details in the commit message itself. :/ |
|
Right, if you are doing the rebase anyway, additional info like in a74fa1f is helpful. If a rebase is not necessary, a new pull should be created anyway, so the commit ends up in the release note logs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking the last interface will always result in preferring the non QT timer interface which results in
walletpassphasere-locking correctly over RPC and over the GUI console.Should fix #7316 for 0.12.
Clean fix for master is in #7317.