Make connect=0 disable automatic outbound connections. #9002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. I've always used it in this way, might as well make it official. |
|
utACK ec4d35cb501b79173c4fc55a8b4f6c3f97659fe6 |
|
Tested ACK ,needs documentation in HelpMessage though |
|
Concept ACK. Don't we want this to disable dns seed queries too though? As-is, I believe this would actually force them. |
I think @gmaxwell checked that |
|
Code review ACK. Agree with documentation update. |
|
utACK ec4d35c Not sure if we need to document this. "Normal people" might be fine with just |
I think we should aim to document everything, whether it exists for "normal people" or not. Developers need documentation too. Testers, too. Have you never forgotten about some specific option / combination of options to do a specific thing? |
Otherwise it just responds to this obvious bit of configuration by trying to connect to "0" in a loop.
|
Travis failure is unrelated (p2p-compactblocks is having transient issues again), re-spinning |
laanwj
added a commit
that referenced
this pull request
Oct 25, 2016
515e264 Make connect=0 disable automatic outbound connections. (Gregory Maxwell)
This was referenced May 18, 2017
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 13, 2018
…ions. 515e264 Make connect=0 disable automatic outbound connections. (Gregory Maxwell)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 21, 2018
Misc upstream PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6077 - Second commit only (first was already applied to 0.11.X and then reverted) - bitcoin/bitcoin#6284 - bitcoin/bitcoin#6489 - bitcoin/bitcoin#6462 - bitcoin/bitcoin#6647 - bitcoin/bitcoin#6235 - bitcoin/bitcoin#6905 - bitcoin/bitcoin#6780 - Excluding second commit (QT) and third commit (requires bitcoin/bitcoin#6993) - bitcoin/bitcoin#6961 - Excluding QT parts, and a small `src/policy/policy.cpp` change which depends on a bunch of other PRs, which we'll have to remember to come back to. - bitcoin/bitcoin#7044 - bitcoin/bitcoin#8856 - bitcoin/bitcoin#9002 Part of #2074 and #2132.
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…ions. 515e264 Make connect=0 disable automatic outbound connections. (Gregory Maxwell)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 15, 2019
…ions. 515e264 Make connect=0 disable automatic outbound connections. (Gregory Maxwell)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Dec 4, 2019
Misc upstream PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6077 - Second commit only (first was already applied to 0.11.X and then reverted) - bitcoin/bitcoin#6284 - bitcoin/bitcoin#6489 - bitcoin/bitcoin#6235 - bitcoin/bitcoin#6905 - bitcoin/bitcoin#6780 - Excluding second commit (QT) and third commit (requires bitcoin/bitcoin#6993) - bitcoin/bitcoin#6961 - Excluding QT parts, and a small `src/policy/policy.cpp` change which depends on a bunch of other PRs, which we'll have to remember to come back to. - bitcoin/bitcoin#7044 - bitcoin/bitcoin#8856 - bitcoin/bitcoin#9002 Part of #2074 and #2132.
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
May 20, 2020
…nections. 8a5f201 Make connect=0 disable automatic outbound connections. (furszy) Pull request description: Coming from upstream@[9002](bitcoin#9002) ACKs for top commit: random-zebra: utACK 8a5f201 Fuzzbawls: ACK 8a5f201 Tree-SHA512: 3ccec00318f35b44b6b843a0cbee99f78cd30354f9363969bf55629490ac4f252a1eb270e669964999a13841ec4df37b155076792d81cbde2df684156910e545
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it just responds to this obvious bit of configuration by
trying to connect to "0" in a loop.