Skip to content

Conversation

@Aniket-pd
Copy link

@Aniket-pd Aniket-pd commented Nov 18, 2025

token #6
Introduces a README.md detailing repository structure, prerequisites, installation steps, usage examples, testing instructions, and licensing for the bdk-dart project.

Introduces a README.md detailing repository structure, prerequisites, installation steps, usage examples, testing instructions, and licensing for the bdk-dart project.
@reez reez linked an issue Nov 18, 2025 that may be closed by this pull request
@reez
Copy link
Collaborator

reez commented Nov 18, 2025

Thanks, I attached the Issue #6 that this would close, and I'll review this this week!

Comment on lines +4 to +5
The repo packages the generated UniFFI bindings (`lib/bdk.dart`) together with the
compiled `libbdkffi` native library so Dart and Flutter apps can work with descriptor-based
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are gitignored though I thought? or maybe we just need to reword?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, you’re right, the generated bindings and native libs are gitignored.
I can reword this section to clarify that the repo provides the sources + UniFFI config, and that the generated artifacts are produced locally rather than checked in

| Path | Purpose |
| ---- | ------- |
| `bdk-ffi/` | Rust sources and build scripts for the underlying `bdk-ffi` crate. |
| `lib/` | Generated Dart bindings (`bdk.dart`) produced by UniFFI-Dart. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implies lib/ contains checked-in bindings which I'm not sure is the case

| `bdk-ffi/` | Rust sources and build scripts for the underlying `bdk-ffi` crate. |
| `lib/` | Generated Dart bindings (`bdk.dart`) produced by UniFFI-Dart. |
| `examples/` | Standalone Dart examples that exercise common workflows. |
| `test/` | Integration-style tests that cover wallet creation, persistence, and networking. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we change this to something like Dart unit tests for wallet construction, offline behavior, persistence or something since we only have offline tests at the moment?

```bash
dart pub get
```
2. Generate the Dart bindings and native binary:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add something like (macOS or Linux host required) here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it’s a good idea since it directly addresses the reviewer’s question about the host requirements for generating bindings

@reez
Copy link
Collaborator

reez commented Nov 18, 2025

@Johnosezele are you interested in reviewing this?

Added LICENSE, LICENSE-APACHE, and LICENSE-MIT files to clarify project licensing under Apache 2.0 or MIT, at the user's option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add README

2 participants