This repository was archived by the owner on Nov 15, 2022. It is now read-only.
Fix Wallet.broadcast function, now returns a tx id as a hex string #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thunderbiscuit can you test this out and see if it fixes #20 ? If this does fix the problem then I'll have to make a new bdk-ffi release and update this PR with that tag. |
|
Tested ACK b33d307. Fixed the broadcast issue. |
notmandatory
force-pushed
the
fix/broadcast
branch
from
1d92bd2 to
e9111f7
Compare
|
ReACK e9111f7. |
thunderbiscuit
approved these changes
Mar 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
bdk-ffito release0.4.1with fixed Wallet.broadcast function, it now returns a tx id as a hex string.Fixes #20
Notes to the reviewers
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing